Repository navigation
fix(mobile): end stalled requests sooner and log where iOS e2e requests stall - #1478
Open
rjzondervan wants to merge 3 commits into
Open
rjzondervan wants to merge 3 commits into
rjzondervan wants to merge 3 commits into
Conversation
…ts stall The iOS e2e run failed twice on 2026-11-04 (PairUnlockUITests:111, VaultFlowsUITests:177) with the app busy and no error: the request the test waited for never reached the replay server. Two changes. Shared client: HttpTimeout with a 15 s connect and a 20 s socket (idle) timeout. On iOS the socket timeout is the NSURLRequest timeout, which otherwise is 60 s, so a stalled request kept the app busy for a minute without a word; now it ends in "Cannot reach this server". There is no cap on the whole request, so a slow but moving transfer completes. Diagnostics for the next occurrence: - server.mjs replay: timestamps on every line, tcp open/close, TLS handshake ok/failed, each request on arrival and on its answer (or "closed unanswered"), so a missing request shows as no connection, a failed handshake, or a connection that never sent one. - ios-run.sh: the simulator log of the Keepiq and KeepiqAutofill processes (URLSession, Network.framework, trust) in simulator.log. - mobile-e2e.yml: media/*.log (replay.log, simulator.log) go into the mobile-media-ios artifact. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Signed-off-by: Robert Zondervan <robert@conduction.nl>
…or log The first run with the app's simulator log wrote 112 MB (936k lines), nearly all XCTest and accessibility chatter. The network, CFNetwork and securityd subsystems hold what the stall diagnosis needs: about 12k lines, 2 MB. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Contributor
Quality Report — ConductionNL/keepiq @
|
| Check | PHP | Vue | Security | License | Tests |
|---|---|---|---|---|---|
| lint | ✅ | ||||
| phpcs | ✅ | ||||
| phpmd | ✅ | ||||
| psalm | ✅ | ||||
| phpstan | ✅ | ||||
| phpmetrics | ✅ | ||||
| eslint | ✅ | ||||
| stylelint | ✅ | ||||
| build | ✅ | ||||
| check-manifest | ✅ | ||||
| test-l10n | ✅ | ||||
| format | ✅ | ||||
| check-l10n-js | ✅ | ||||
| check-schema-l10n | ✅ | ||||
| composer | ✅ | ✅ 114/114 | |||
| npm | ✅ | ✅ 661/661 | |||
| app:check-code | ⏭️ | ||||
| info.xml | ✅ | ||||
| REUSE | ✅ | ||||
| lockfile sync | ✅ | ||||
| PHPUnit | ✅ 3040/3040 · 3 skipped | ||||
| Newman | ✅ 177/177 · 20 skipped | ||||
| Playwright | ⏭️ deferred: E2E runs locally and on the promotion path only. This pull request targets development, so the suite is asked once per promotion into beta and main rather than once per push per open pull request. Run it locally with npx playwright test, or from the Actions tab on a branch with no open pull request into development. |
||||
| Hydra gates | ✅ |
Quality workflow — 2026-11-05 11:30 UTC
Download the full PDF report from the workflow artifacts.
The new simulator log caught the stall on 2026-11-05 (run 42017106996,
PairUnlockUITests:111): TCP and the TLS handshake reach the server's
certificate, the app hands it to trustd ("Completed async eval
kickoff"), and trustd never answers; 60 of 61 evaluations in that run
returned in about 5 ms. The request then times out at 20 s. Nothing is
wrong in the app or the replay.
- xcodebuild runs each class with -retry-tests-on-failure
-test-iterations 2. A test that only passed on its retry is posted as
a GitHub warning, so a flake of our own still shows.
- The simulator log also takes the trustd process, so the next hang
shows what it waited on.
- Each class's xcodebuild output is kept as <class>.log in the
artifact (media/*.log), which the warning is read from.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Contributor
Quality Report — ConductionNL/keepiq @
|
| Check | PHP | Vue | Security | License | Tests |
|---|---|---|---|---|---|
| lint | ✅ | ||||
| phpcs | ✅ | ||||
| phpmd | ✅ | ||||
| psalm | ✅ | ||||
| phpstan | ✅ | ||||
| phpmetrics | ✅ | ||||
| eslint | ✅ | ||||
| stylelint | ✅ | ||||
| build | ✅ | ||||
| check-manifest | ✅ | ||||
| test-l10n | ✅ | ||||
| format | ✅ | ||||
| check-l10n-js | ✅ | ||||
| check-schema-l10n | ✅ | ||||
| composer | ✅ | ✅ 114/114 | |||
| npm | ✅ | ✅ 661/661 | |||
| app:check-code | ⏭️ | ||||
| info.xml | ✅ | ||||
| REUSE | ✅ | ||||
| lockfile sync | ✅ | ||||
| PHPUnit | ✅ 3040/3040 · 3 skipped | ||||
| Newman | ✅ 177/177 · 20 skipped | ||||
| Playwright | ⏭️ deferred: E2E runs locally and on the promotion path only. This pull request targets development, so the suite is asked once per promotion into beta and main rather than once per push per open pull request. Run it locally with npx playwright test, or from the Actions tab on a branch with no open pull request into development. |
||||
| Hydra gates | ✅ |
Quality workflow — 2026-11-05 13:36 UTC
Download the full PDF report from the workflow artifacts.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
The iOS
Mobile e2ejob failed twice on 2026-11-04 in a way the earlier flake fixes (#1432, #1435) don't cover:PairUnlockUITests:111VaultFlowsUITests:177From the
mobile-media-iosvideos and the replay log:POST /login/v2, resp.POST /extension/pair) never reached the replay server; the requests before and after it did.::1 Connection refusedlines come from the test runner's offline toggles and fall back to IPv4 within a millisecond), the replay's offline mode (OfflineUITests runs later and switches it off), andcheckRoom().Where the request stalls (connection, TLS or the app) can't be seen yet: the app's own log isn't captured.
What
Shared client (
KeepiqApi.httpClient):HttpTimeoutwith a 15 s connect and a 20 s socket (idle) timeout.Diagnostics for the next occurrence:
mobile/e2e/server.mjsreplay: timestamps on every line; TCP open/close; TLS handshake ok/failed with the reason; each request on arrival and on its answer, orclosed unanswered.mobile/e2e/ios-run.sh: the simulator log of theKeepiqandKeepiqAutofillprocesses (URLSession, Network.framework, trust) insimulator.log.mobile-e2e.yml:media/*.log(replay.log,simulator.log) go into themobile-media-iosartifact.Verification
:shared:jvmTest: 222 tests, 0 failures (1 skipped), including the newKeepiqApiTest.everyRequestCarriesTheConnectAndSocketTimeouts.node:22with a normal request, a 401, an untrusted certificate, a stalled body and an offline drop; each case logs as intended.Mobile e2eandMobileruns are the proof; after that, check thatsimulator.login the artifact is non-empty.This does not make the flake disappear: a stalled request still fails the test, just with an error on screen and with logs that say where it stalled.
🤖 Generated with Claude Code