Repository navigation
Reports moves under Advanced in the navigation - #1198
Merged
Merged
Conversation
The generic Reports entry leaves the footer for the settings foldout, which nextcloud-vue now labels Advanced.
Contributor
Quality Report — ConductionNL/keepiq @
|
| Check | PHP | Vue | Security | License | Tests |
|---|---|---|---|---|---|
| lint | ✅ | ||||
| phpcs | ✅ | ||||
| phpmd | ✅ | ||||
| psalm | ✅ | ||||
| phpstan | ✅ | ||||
| phpmetrics | ✅ | ||||
| eslint | ✅ | ||||
| stylelint | ✅ | ||||
| build | ✅ | ||||
| check-manifest | ✅ | ||||
| test-l10n | ✅ | ||||
| format | ✅ | ||||
| check-l10n-js | ✅ | ||||
| check-schema-l10n | ✅ | ||||
| composer | ✅ | ✅ 114/114 | |||
| npm | ✅ | ✅ 660/660 | |||
| app:check-code | ⏭️ | ||||
| info.xml | ✅ | ||||
| REUSE | ✅ | ||||
| lockfile sync | ✅ | ||||
| PHPUnit | 🚨 NO VERDICT — enabled but never ran | ||||
| Newman | 🚨 NO VERDICT — enabled but never ran | ||||
| Playwright | ⏭️ deferred: E2E runs locally and on the promotion path only. This pull request targets development, so the suite is asked once per promotion into beta and main rather than once per push per open pull request. Run it locally with npx playwright test, or from the Actions tab on a branch with no open pull request into development. |
||||
| Hydra gates | ⏭️ |
Quality workflow — 2026-10-07 07:34 UTC
Download the full PDF report from the workflow artifacts.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ruben asked to rename the settings foldout at the bottom of the navigation to "Advanced" everywhere, and to put Reports under it in every app. The label comes from nextcloud-vue (ConductionNL/nextcloud-vue#1347); this PR moves the Reports entry.
What changes
src/manifest.json: the generic Reports entryReportsMenumoves fromsection: "footer"tosection: "settings". Domain-specific report pages in the main menu stay where they are.app-chromee2e: the footer no longer lists Reports, and the Reports test opens the foldout before it clicks the entry.Checked with the library's own
buildManifest: the entry ends up top-level insettingsin every profile this app ships.Verified
check:manifestpasses. Playwright was not run; Ruben asked for the look first and heavier verification later.Heads-up
Hydra gates 104 (
reports-one-page) and 107 (app-chrome) still require Reports insection: "footer"(ADR-112 D3, ADR-114 D1/D3). They will flag this PR until those gates and ADRs follow Ruben's decision.