Skip to content

Reports moves under Advanced in the navigation - #1198

Merged
rubenvdlinde merged 1 commit into
developmentfrom
feat/reports-under-advanced
Oct 7, 2026
Merged

rubenvdlinde merged 1 commit into
developmentfrom
feat/reports-under-advanced

Conversation

@rubenvdlinde

Copy link
Copy Markdown
Contributor

Ruben asked to rename the settings foldout at the bottom of the navigation to "Advanced" everywhere, and to put Reports under it in every app. The label comes from nextcloud-vue (ConductionNL/nextcloud-vue#1347); this PR moves the Reports entry.

What changes

  • src/manifest.json: the generic Reports entry ReportsMenu moves from section: "footer" to section: "settings". Domain-specific report pages in the main menu stay where they are.
  • app-chrome e2e: the footer no longer lists Reports, and the Reports test opens the foldout before it clicks the entry.

Checked with the library's own buildManifest: the entry ends up top-level in settings in every profile this app ships.

Verified

check:manifest passes. Playwright was not run; Ruben asked for the look first and heavier verification later.

Heads-up

Hydra gates 104 (reports-one-page) and 107 (app-chrome) still require Reports in section: "footer" (ADR-112 D3, ADR-114 D1/D3). They will flag this PR until those gates and ADRs follow Ruben's decision.

The generic Reports entry leaves the footer for the settings foldout,
which nextcloud-vue now labels Advanced.
@github-actions

github-actions Bot commented Oct 7, 2026

Copy link
Copy Markdown
Contributor

Quality Report — ConductionNL/keepiq @ 737696d

Check PHP Vue Security License Tests
lint ✅
phpcs ✅
phpmd ✅
psalm ✅
phpstan ✅
phpmetrics ✅
eslint ✅
stylelint ✅
build ✅
check-manifest ✅
test-l10n ✅
format ✅
check-l10n-js ✅
check-schema-l10n ✅
composer ✅ ✅ 114/114
npm ✅ ✅ 660/660
app:check-code ⏭️
info.xml ✅
REUSE ✅
lockfile sync ✅
PHPUnit 🚨 NO VERDICT — enabled but never ran
Newman 🚨 NO VERDICT — enabled but never ran
Playwright ⏭️ deferred: E2E runs locally and on the promotion path only. This pull request targets development, so the suite is asked once per promotion into beta and main rather than once per push per open pull request. Run it locally with npx playwright test, or from the Actions tab on a branch with no open pull request into development.
Hydra gates ⏭️

Quality workflow — 2026-10-07 07:34 UTC

Download the full PDF report from the workflow artifacts.

@rubenvdlinde
rubenvdlinde marked this pull request as ready for review October 7, 2026 07:49
@rubenvdlinde
rubenvdlinde merged commit 4934a64 into development Oct 7, 2026
49 of 50 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant