Repository navigation
feat(mobile): encrypted offline store on iOS and no save-password prompt after Keepiq's forms (tasks 1.6.1, 3.2.1) - #1184
Merged
Conversation
SQLCipher Community Edition 4.19.0, built from the pinned release source (SHA-256 checked) into the KeepiqShared klib per iOS target, linked by the SQLDelight native driver instead of the system SQLite. The database key is 32 random bytes per account in a non-biometric Keychain item (AfterFirstUnlockThisDeviceOnly, through KeychainStorage). The store refuses to open when SQLCipher is missing (PRAGMA cipher_version), and a file whose key is gone starts again empty. Unpair deletes file and key; suite change and offline caching off empty it through VaultSync, as on Android. The iOS app opens its sessions through IosVaultSession with the store and sync; the lock and wrap deletion of a sync reach AppModel. Tests: the store on the iOS simulator (IosEncryptedStoreTest) and OfflineUITests, which reads the stored vault after the replay drops every connection (POST /__e2e/offline).
….2.1) iOS reads the user name and password fields when they leave the view hierarchy and offers to save what it finds (WWDC 2018 session 204: "Make sure to only clear the username and password fields after they've been removed from the view hierarchy. This way, we can read out the data and save it into credential."). The item form, the Send form and the AutoFill sheet's add-login form now empty their secret fields once the save went through, wait a moment for the fields to update, and only then leave. The fields stay SecureFields, so VoiceOver announces them as secure as before. VaultFlowsUITests.expectNoSavePasswordPrompt fails again when the prompt comes; AutofillUITests records whether it came after the add-login form.
Contributor
Quality Report — ConductionNL/keepiq @
|
| Check | PHP | Vue | Security | License | Tests |
|---|---|---|---|---|---|
| lint | ✅ | ||||
| phpcs | ✅ | ||||
| phpmd | ✅ | ||||
| psalm | ✅ | ||||
| phpstan | ✅ | ||||
| phpmetrics | ✅ | ||||
| eslint | ✅ | ||||
| stylelint | ✅ | ||||
| build | ✅ | ||||
| check-manifest | ✅ | ||||
| test-l10n | ✅ | ||||
| format | ✅ | ||||
| check-l10n-js | ✅ | ||||
| check-schema-l10n | ✅ | ||||
| composer | ✅ | ✅ 114/114 | |||
| npm | ✅ | ✅ 660/660 | |||
| app:check-code | ⏭️ | ||||
| info.xml | ✅ | ||||
| REUSE | ✅ | ||||
| lockfile sync | ✅ | ||||
| PHPUnit | ❌ | ||||
| Newman | ❌ | ||||
| Playwright | ⏭️ deferred: E2E runs locally and on the promotion path only. This pull request targets development, so the suite is asked once per promotion into beta and main rather than once per push per open pull request. Run it locally with npx playwright test, or from the Actions tab on a branch with no open pull request into development. |
||||
| Hydra gates | ✅ |
Quality workflow — 2026-10-05 22:10 UTC
Download the full PDF report from the workflow artifacts.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this changes
Two iOS gaps of
clients-mobile-appsclose: the encrypted offline store (task 1.6.1) and the "Save Password?" offer after Keepiq's own forms (task 3.2.1).Task 1.6.1: the encrypted offline store on iOS
sqlciphercinterop bundleslibsqlcipher.ainto the klib.linkSqliteoff. The Xcode project no longer linkslibsqlite3.tbd, so the system SQLite cannot answer the store's calls.IosEncryptedStoreopens one store per account with a raw 256-bit key. The key is 32 random bytes in a Keychain item (KeychainStorage:kSecAttrAccessibleAfterFirstUnlockThisDeviceOnly, no biometric access control). The store folder is excluded from backups.PRAGMA cipher_versionanswers nothing, and then deletes the plaintext file it would leave. A file whose key is gone starts again empty.IosVaultSession.opengives the app a session with the store andVaultSync, asVaultSession.opendoes on Android. Names, URLs and folder names are sealed under the unlock key by the sharedVaultStore.client.onWipe). A suite change, a master-password change and offline caching turned off empty the store throughVaultSync. A sync lock reachesAppModelthroughSyncLock, which also deletes the biometric and PIN wraps.POST /__e2e/offline, which drops every other connection.Task 3.2.1: no "Save Password?" after Keepiq's forms
iOS reads the user name and password fields when they leave the view hierarchy. Apple says so in WWDC 2018 session 204, "Automatic Strong Passwords and Security Code AutoFill": "Make sure to only clear the username and password fields after they've been removed from the view hierarchy. This way, we can read out the data and save it into credential."
Keepiq does the reverse. After a save went through, the item form, the Send form and the AutoFill sheet's add-login form empty their secret fields, wait 200 ms and then leave. The fields stay
SecureFields, so VoiceOver still announces them as secure. A failed save keeps what the user typed.VaultFlowsUITests.expectNoSavePasswordPromptfails again when the prompt comes.AutofillUITestsrecords whether it came after the add-login form.Verified
Results pending: CI runs on this PR. This section is filled in once the five mobile checks are read.
Inherited
PHPUnit pgsql, Newman and Quality Report are red on
developmentand are not touched here.🤖 Generated with Claude Code