Repository navigation
test(integriq): keep flow-native-sync off the shared container; tick two live checks - #3697
Merged
Merged
Conversation
…ntainer With no OCC_CMD and no occ above the checkout, the spec fell back to a container named "nextcloud", which is the shared dev container, and ran the synchronization generator and the FlowRunWorker there. The container must now be named (NC_CONTAINER, INTEGRIQ_E2E_CONTAINER or NEXTCLOUD_CONTAINER), or the spec stops with its existing error. Assisted-by: ClaudeCode:claude-opus-5-5
…ve checks Both run on a fresh instance after occ upgrade: the four bookkeeping templates are dormant catalogue items on the Marketplace page, and the settlement pull job is scheduled. Assisted-by: ClaudeCode:claude-opus-5-5
rubenvdlinde
requested review from
Rem-Dam,
SudoThijn and
remko48
as code owners
November 17, 2026 09:00
Contributor
Quality Report — ConductionNL/integriq @
|
| Check | PHP | Vue | Security | License | Tests |
|---|---|---|---|---|---|
| lint | ✅ | ||||
| phpcs | ❌ | ||||
| phpmd | ❌ | ||||
| psalm | ❌ | ||||
| phpstan | ✅ | ||||
| phpmetrics | ✅ | ||||
| eslint | ✅ | ||||
| stylelint | ❌ | ||||
| build | ✅ | ||||
| build | ✅ | ||||
| check-specs | ✅ | ||||
| test-l10n | ✅ | ||||
| format | ❌ | ||||
| check-schema-l10n | ❌ | ||||
| check-l10n-js | ❌ | ||||
| composer | ✅ | ✅ 146/146 | |||
| npm | ✅ | ✅ 642/642 | |||
| app:check-code | ⏭️ | ||||
| info.xml | ✅ | ||||
| REUSE | ❌ | ||||
| lockfile sync | ✅ | ||||
| PHPUnit | ❌ | ||||
| Newman | ❌ | ||||
| Playwright | ⏭️ deferred: E2E runs locally and on the promotion path only. This pull request targets development, so the suite is asked once per promotion into beta and main rather than once per push per open pull request. Run it locally with npx playwright test, or from the Actions tab on a branch with no open pull request into development. |
||||
| Hydra gates | ❌ | ||||
| Hydra gates (axe) | ✅ |
Quality workflow — 2026-11-17 09:51 UTC
Download the full PDF report from the workflow artifacts.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Shared-container guard
tests/e2e/spec-coverage/flow-native-sync.spec.tsresolved occ as:OCC_CMD, else anoccfile above the checkout, else a container namednextcloud. That is the shared dev container. On a host run against a throwaway rig (base URL set, no occ above the checkout), the spec ranintegriq:synchronization-to-flowthere. The later tests would have run OpenRegister's FlowRunWorker there too. The container must now be named inNC_CONTAINER,INTEGRIQ_E2E_CONTAINERorNEXTCLOUD_CONTAINER, or the spec stops with its existing error. CI is unchanged: it findsoccabove the checkout first.Verified: with
NC_CONTAINERnaming the rig, the spec passes 6 with 1 skipped on a fresh NC 34.0.6 + OpenRegister main instance.Live checks ticked
occ upgradethe four bookkeeping templates are dormantcatalog_items in their categories, and the Marketplace page lists them under Source templates.background-job:listshowsPaymentSettlementPullJobafter the upgrade; PaymentSettlementServiceTest 5/5.Local checks
npm run lint: 0 errors.composer check:stricthas nothing of this diff to measure. Its one run is in fix(integriq): live pass: traces, cron job runs, API-key consumers #3693.AI assistance: prepared with Claude Code (claude-opus-5-5) during a live-pass lane; reviewed by Ruben before merge.