Skip to content

test(integriq): keep flow-native-sync off the shared container; tick two live checks - #3697

Merged
rubenvdlinde merged 2 commits into
developmentfrom
quality/livepass-integriq-3
Nov 17, 2026
Merged

rubenvdlinde merged 2 commits into
developmentfrom
quality/livepass-integriq-3

Conversation

@rubenvdlinde

Copy link
Copy Markdown
Contributor

Shared-container guard

tests/e2e/spec-coverage/flow-native-sync.spec.ts resolved occ as: OCC_CMD, else an occ file above the checkout, else a container named nextcloud. That is the shared dev container. On a host run against a throwaway rig (base URL set, no occ above the checkout), the spec ran integriq:synchronization-to-flow there. The later tests would have run OpenRegister's FlowRunWorker there too. The container must now be named in NC_CONTAINER, INTEGRIQ_E2E_CONTAINER or NEXTCLOUD_CONTAINER, or the spec stops with its existing error. CI is unchanged: it finds occ above the checkout first.

Verified: with NC_CONTAINER naming the rig, the spec passes 6 with 1 skipped on a fresh NC 34.0.6 + OpenRegister main instance.

Live checks ticked

  • platform-bookkeeping-catalogue-items Task 1: after occ upgrade the four bookkeeping templates are dormant catalog_items in their categories, and the Marketplace page lists them under Source templates.
  • messaging-payment-command-settlements-and-point-of-sale Task 3: background-job:list shows PaymentSettlementPullJob after the upgrade; PaymentSettlementServiceTest 5/5.

Local checks

AI assistance: prepared with Claude Code (claude-opus-5-5) during a live-pass lane; reviewed by Ruben before merge.

…ntainer

With no OCC_CMD and no occ above the checkout, the spec fell back to a
container named "nextcloud", which is the shared dev container, and ran the
synchronization generator and the FlowRunWorker there. The container must now
be named (NC_CONTAINER, INTEGRIQ_E2E_CONTAINER or NEXTCLOUD_CONTAINER), or
the spec stops with its existing error.

Assisted-by: ClaudeCode:claude-opus-5-5
…ve checks

Both run on a fresh instance after occ upgrade: the four bookkeeping templates
are dormant catalogue items on the Marketplace page, and the settlement pull
job is scheduled.

Assisted-by: ClaudeCode:claude-opus-5-5
@rubenvdlinde
rubenvdlinde merged commit eede77e into development Nov 17, 2026
1 check passed
@github-actions

Copy link
Copy Markdown
Contributor

Quality Report — ConductionNL/integriq @ a7ffbd3

Check PHP Vue Security License Tests
lint ✅
phpcs ❌
phpmd ❌
psalm ❌
phpstan ✅
phpmetrics ✅
eslint ✅
stylelint ❌
build ✅
build ✅
check-specs ✅
test-l10n ✅
format ❌
check-schema-l10n ❌
check-l10n-js ❌
composer ✅ ✅ 146/146
npm ✅ ✅ 642/642
app:check-code ⏭️
info.xml ✅
REUSE ❌
lockfile sync ✅
PHPUnit ❌
Newman ❌
Playwright ⏭️ deferred: E2E runs locally and on the promotion path only. This pull request targets development, so the suite is asked once per promotion into beta and main rather than once per push per open pull request. Run it locally with npx playwright test, or from the Actions tab on a branch with no open pull request into development.
Hydra gates ❌
Hydra gates (axe) ✅

Quality workflow — 2026-11-17 09:51 UTC

Download the full PDF report from the workflow artifacts.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant