Repository navigation
feat(integriq): build open-formulieren-submits-into-its-case - #3675
Merged
rubenvdlinde merged 3 commits intoNov 17, 2026
Merged
rubenvdlinde merged 3 commits into
rubenvdlinde merged 3 commits into
Conversation
An Open Formulieren submit creates its case in the inbound request through OpenRegister's form submit path (submission id as idempotency key and externalReference; 201 or the refusal's status), with one audit-log line of body hash, time and outcome and no staged submission. A form mapping is checked against its destination schema by OpenRegister's form destination validator before it may be active. Assisted-by: ClaudeCode:claude-opus-5-5
occ integriq:openformulieren:drain: lists the received and failed staged submissions, and with --apply submits each through the inbound path as the connection account (submission id as idempotency key) and marks it handed_off with its case. The ObjectService test stub and its subclasses accept main's ObjectSaveOptions. Assisted-by: ClaudeCode:claude-opus-5-5
rubenvdlinde
requested review from
Rem-Dam,
SudoThijn,
WilcoLouwerse,
bbrands02,
remko48 and
rjzondervan
as code owners
November 16, 2026 19:46
…s-case [skip ci] Takes development's openregister main stubs (ObjectSaveOptions and friends, saveObject(object, options, rbac, multitenancy)) over the branch's interim options parameter; the drain test double and the rule-processor golden follow that signature. Assisted-by: ClaudeCode:claude-opus-5-5
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Builds
openspec/changes/open-formulieren-submits-into-its-case(integriq's half of the form-submits-into-its-destination change): an Open Formulieren submit creates its case in the inbound request, and a form mapping is checked against its case schema before it may be active.Tasks done
openformulieren_form_mappingwithisEnabledtrue runs OpenRegister'sFormDestinationValidatorInterfaceagainst the destination schema (MappingCheck,OpenFormulierenMappingGuardListeneron OpenRegister's creating/updating events). Findings refuse the save with 422 and the findings (required-unmapped on caseType, ...). A disabled mapping saves unchecked, so it can be kept as a draft. The mapping schema gainsdestinationRegister(defaultdossiq),destinationSchema(defaultcase),fixedValues(for example the case type) andpropertyMap(contract field to destination property; by default title→title, summary→description, channel→intakeChannel; priority is derived by a dossiq case and not written).OpenFormulierenController::inboundmaps the payload and calls OpenRegister'sFormSubmitServiceInterface::submitin the same request (DestinationSubmitter), as the connection's account, with the submission id as idempotency key andexternalReference. It answers 201 with OpenRegister's answer (reference, id, ...), the refusal's status with its findings (422), or 503 when the destination cannot be written now. Noopenformulieren_submissionis written.CriticalActionPerformedEvent) with the body's sha256, the time and the outcome; nothing is kept to process later.occ integriq:openformulieren:drain: a dry run lists thereceivedandfailedsubmissions;--applysubmits each through the new path as the connection account and marks ithanded_offwith its case. Idempotent: the submission id is the key, so running it twice creates no second case.Tasks left, and why
handoff()path waits for a drain that reports zero pending on the live instances (the proposal's rollback rule).composer check:strict/openspec validate: phpcs and phpstan ran clean on every touched lib file; the full strict run is left to CI.Tests
New:
FormDestinationWriteTest,MappingCheckTest,DestinationSubmitterTest,SubmissionDrainTest,OpenFormulierenMappingGuardListenerTest(201, 422, idempotent repeat, the no-staging control, the mapping refusal). Updated the three Open Formulieren controller tests for the new inbound answer, the registration-order and service-registrar goldens for the new alias and listener, and the rule-processors golden for the stub's new trailing argument. Test stubs for OpenRegister's form classes and main's save options are copies of main's method shapes; theObjectServicestub and its four test subclasses accept main'sObjectSaveOptions.Suite
Unit suite before (development): 4 failing tests (JobsControllerTest::testUnknownJobIsNotFound, two CallServiceTest list-method tests, SynchronizationSynchronizeEntryGoldenTest). After: the same 4, nothing new; 9552 tests.
Generated by Claude Code