Repository navigation
feat(integriq): build send-at-on-the-messaging-leaf - #3632
Merged
rubenvdlinde merged 4 commits intoNov 17, 2026
Merged
Conversation
Seed the smtp-mail source that OpenRegister's messaging leaf sends e-mail
through (MessageDispatchProvider::EMAIL_SOURCE). Like the SMS sources it is
an HTTP source in mock mode: the leaf POSTs {to, subject, text, html?,
replyTo?} with its Message-ID header, and the mock answers accepted without
sending. Its address is a reserved .invalid placeholder until an admin
points it at a mail relay. Listed in the catalog under Messaging; the
catalog seed digests move by exactly this entry.
Assisted-by: ClaudeCode:claude-opus-5-5
rubenvdlinde
requested review from
WilcoLouwerse,
bbrands02 and
rjzondervan
as code owners
November 14, 2026 17:26
rubenvdlinde
added a commit
to ConductionNL/openregister
that referenced
this pull request
Nov 14, 2026
Task 1.1 is complete: the smtp-mail source seed is in integriq (ConductionNL/integriq#3632). Assisted-by: ClaudeCode:claude-opus-5-5
…kip ci] Development added seeds of its own, so the catalog seed digests are recomputed with smtp-mail on top of them; the collected catalog differs from development's by exactly the smtp-mail entry. Assisted-by: ClaudeCode:claude-opus-5-5
…kip ci] Resolve the seed golden-hash conflict: both lines changed the catalog seeds, so the hashes are recomputed from the merged seeds. Assisted-by: ClaudeCode:claude-opus-5-5
…kip ci] Golden hashes of the catalog seed recomputed over development's catalog plus this branch's SMTP mail source. Assisted-by: ClaudeCode:claude-opus-5-5
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Builds the integriq part of OpenRegister's
send-at-on-the-messaging-leaf(task 1.1): the seededsmtp-mailsource. OpenRegister'sPOST /api/integrations/email/sendsends through this source (MessageDispatchProvider::EMAIL_SOURCE, in ConductionNL/openregister#10534).Done
lib/Settings/register.d/smtp-mail-source.json: anapisourcesmtp-mail("SMTP mail relay"), built the same way ascmcom-sms/twilio-sms. It is in mock mode (configuration.mock: true, cannedacceptedresponse) and enabled, so the e-mail channel works end to end without sending any mail. Its address is a reserved.invalidplaceholder until an admin points it at an HTTP mail relay and removesmock. The leaf POSTs{to, subject, text, html?, replyTo?}with its mintedMessage-IDheader.CatalogRegistryService:smtp-mailis listed under the Messaging category, beside the SMS sources.Left
Tests
SmtpMailSourceSeedTest(2 tests): the seed payload's shape (mock, placeholder host, JSON headers) and its catalog category. A wrong category makes it fail.CatalogRegistrySeedGoldenTestdigests updated. Before updating, I diffed the collected catalog and payloads against development, and they differ only by the newsmtp-mailentry.SynchronizationSynchronizeEntryGoldenTestis timing-dependent: it passed and then failed on plain development too.validate-register.jsandvalidate-json-strict.jspass. phpcs and phpstan are clean on the touched PHP.Generated by Claude Code