Repository navigation
feat(integriq): build observability-opentelemetry-export-errors-and-app-spans - #3602
Merged
rubenvdlinde merged 6 commits intoNov 17, 2026
Conversation
…pp-spans [skip ci] Assisted-by: ClaudeCode:claude-opus-5-5
rubenvdlinde
requested review from
Rem-Dam,
SudoThijn,
WilcoLouwerse,
bbrands02,
remko48 and
rjzondervan
as code owners
November 14, 2026 08:11
…rt-errors-and-app-spans [skip ci] Regenerate l10n/en.js and l10n/nl.js from the merged .json catalogues (30 keys were present in the .json but missing from the .js). Assisted-by: ClaudeCode:claude-opus-5-5
…etry-export-errors-and-app-spans [skip ci]
…rt-errors-and-app-spans [skip ci] Development rebuilt SettingsService around the retention settings; the error sink methods move onto it, its tests into SettingsServiceErrorSinkTest, and the service factory now passes the error sink store, which it did not before, so the admin endpoint no longer throws. Assisted-by: ClaudeCode:claude-opus-5-5
…rt-errors-and-app-spans [skip ci] Resolve the l10n and AdminSettings.vue conflicts by keeping both sides' strings and @SPEC tags. Assisted-by: ClaudeCode:claude-opus-5-5
…rt-errors-and-app-spans [skip ci] Assisted-by: ClaudeCode:claude-opus-5-5
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Builds
openspec/changes/observability-opentelemetry-export-errors-and-app-spans(tasks 6 to 9; part two ofobservability-opentelemetry-export, whose tasks 1 to 5 are on development).Tasks done
ErrorSinkListeneronOCP\Log\BeforeMessageLoggedEventqueues oneErrorSinkExportJobper selected message (app list + minimum level). It makes no HTTP call, never logs, swallows its own errors and ignores messages it causes itself. The job retries 3 times (after 5, 10 and 20 minutes), then drops the event silently. Registered throughObservabilityBindings, with a wiring test.SentryEnvelopeExporter(DSN →/api/{id}/envelope/,X-Sentry-Authfrom the key) andOtlpLogExporter({endpoint}/v1/logs, OTLP JSONresourceLogs). The message and file are redacted before queueing; this uses the newBodyRedactor::redactText(), which also strips BSN-shaped numbers.SpanExportRequestedEventanswersno-listeneruntil it is handled.SpanExportRequestedListenervalidates spans (rejection reasons name the field), drops attributes outside the allowlist, answersexport-disabledwhen export is off, and queues valid spans through the same job, which exports them withservice.nameset to the sending app. The contract for sibling apps, including theclass_exists()guard, is indocs/features/opentelemetry.md.errorsink_*settings with validation: an enabled sink needs an endpoint, andhttpis accepted only for a host marked internal.GET/PUT /api/admin/errorsink(documented in openapi.json). An admin section next to the collector settings. 11 frontend and 9 backend strings, in en and nl.Tasks left
tests/e2e/opentelemetry-export.spec.ts(task 9) needs a running Nextcloud and is left unchecked.SettingsServiceTest::testAnEnabledErrorSinkNeedsAnEndpointis done.SpanExportRequestedEventfrom its request path.tests/Helpers/ServiceListenerDispatcher, wired by the realApplication::register(), because Nextcloud's own dispatcher is not in the unit autoload.Tests
40 new tests: ErrorSinkListenerTest 7, ErrorSinkExporterTest 8, SettingsServiceTest 6, SpanExportRequestedListenerTest 10, SpanExportRequestedEventTest 2, BodyRedactorTextTest 2, ErrorSinkSettingsControllerTest 4, ObservabilityBindingsTest +1.
Unit suite: before, Tests: 8493, Errors: 2, Failures: 3; after, Tests: 8533, Errors: 2, Failures: 2. The remaining errors and failures are inherited from development (CallServiceTest x2, JobsControllerTest::testUnknownJobIsNotFound x2). The third failure in the before run, SynchronizationSynchronizeEntryGoldenTest, also fails on development; it passed in this run.
Diff check: php -l clean; phpcs 0 errors; phpstan on the changed lib files OK; eslint clean on the touched Vue files; check:l10n-js up to date; test:l10n OK.
Generated by Claude Code