Repository navigation
feat(integriq): build sources-route-distance-and-rdw-lookup - #3595
Merged
rubenvdlinde merged 15 commits intoNov 17, 2026
Merged
rubenvdlinde merged 15 commits into
rubenvdlinde merged 15 commits into
Conversation
A sibling app calls a connection it declared through ConnectionCallRequestedEvent, and asks the road distance between two postcodes through RouteDistanceRequestedEvent. Adds dormant source templates for RDW open data, OpenRouteService and TomTom. Assisted-by: ClaudeCode:claude-opus-5-5
rubenvdlinde
requested review from
Rem-Dam,
SudoThijn,
WilcoLouwerse,
bbrands02,
remko48 and
rjzondervan
as code owners
November 14, 2026 07:55
…ookup [skip ci] Keeps both sides' sibling listeners (connection call and route distance from this branch, form submission registration and service fetch from development) in EventListenerBindings and the registration-order fixture, and re-pins the catalog seed golden hashes to the merged seed. Assisted-by: ClaudeCode:claude-opus-5-5
…d-rdw-lookup [skip ci]
…ookup [skip ci] The seed golden hashes cover both sides' seed changes. Assisted-by: ClaudeCode:claude-opus-5-5
…s to hold the maintainability floor [skip ci] RouteDistanceService::distance (61 lines, McCabe 10) becomes planner, places and routeMeters; place, metersOf, linkedSource and requestRefusal lose their extra branches to small helpers with the same outcomes, the path check unchanged. The two command events share their answer half through the CommandAnswer trait, so their public methods stay as they were. Against development: duplication 3.80 = 3.80, unit_size 3.55 = 3.55, unit_complexity 3.89 -> 3.91, module_coupling 5.03 -> 5.04. Assisted-by: ClaudeCode:claude-opus-5-5
…ookup [skip ci] Assisted-by: ClaudeCode:claude-opus-5-5
…ookup [skip ci] Assisted-by: ClaudeCode:claude-opus-5-5
…ookup [skip ci] Assisted-by: ClaudeCode:claude-opus-5-5
…s to hold the maintainability floor [skip ci] call(), linkedSource(), distance() and the two request listeners' handle() each split into named steps (validSource, callSource, answer, sourceOf, routeBetween, distanceAnswer, answerFor, ask); refusal reasons move into a local before the call. Behaviour unchanged. unit_size on the tree merged with development is 3.59 (development 3.58); no property below development. Assisted-by: ClaudeCode:claude-opus-5-5
Assisted-by: ClaudeCode:claude-opus-5-5
…ookup [skip ci] Assisted-by: ClaudeCode:claude-opus-5-5
…ces beside their listeners [skip ci] Both services are only reached from their event listeners; placing them in lib/EventListener (as ExchangeRateService already is) keeps the code inside one component and restores the maintainability floor (3.56 after merge). No behaviour change. Assisted-by: ClaudeCode:claude-opus-5-5
…ookup [skip ci] Both sides changed the seeded catalogue; the golden hashes are recomputed from the merged tree. Assisted-by: ClaudeCode:claude-opus-5-5
…ookup [skip ci] Seed golden hashes recomputed on the merged tree: both sides changed the seed catalogue. Assisted-by: ClaudeCode
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Builds
openspec/changes/sources-route-distance-and-rdw-lookup.Tasks done
ConnectionCallRequestedEvent+ConnectionCallRequestedListenerover a newConnectionCallService. Finds the app's declaredapp_connectionrow, calls the linked source throughCallServiceInterface::call()with the source's own credential, and answersstatus,body(decoded JSON or raw text) andsourceSlug. Refusesnot-declared,not-linked(with the connection's title),invalid(method other than GET/POST, a path that leaves the source's location, non-scalar query values) andcall-failed; never throws to the caller.RouteDistanceRequestedEvent+ listener overRouteDistanceService. Places both postcodes through PDOK, asks the linked planner (OpenRouteService or TomTom, chosen byconfiguration.routeProvider, else the slug), answersdistanceKmOneWay(one decimal),routeProvider,fromMunicipality,toMunicipality. Refusesunknown-postcode(naming it),unsupported-mode,unsupported-provider,geocoder-unavailable,no-route.rdw-open-data(no credential),route-planner-openrouteserviceandroute-planner-tomtom(credential bycredentialRef), with catalogue categories Government registers and Geo / Maps.docs/features/connection-calls.mdlists both events, their fields and refusal codes. No new user-visible backend strings, so no l10n keys.EventListenerBindings::registerSiblingRequestListeners(), with the other sibling-request commands.Tasks left, and why
openspec validate --strictandcomposer check:strict(not available in this environment; phpcs and phpstan were run on every touched lib file instead, both clean).Tests added
ConnectionCallServiceTest(10 tests): the RDW plate lookup against a recorded RDW answer through the real event and listener, not-linked, not-declared, a gone source,..refused before anything is read, every way out of the location, POST JSON body, call failure, listener failure.RouteDistanceServiceTest(11 tests): 2611 AB to 3011 AD by car is 15.8 km on OpenRouteService (recorded answer), TomTom e-bike, 0000 XX and an unplaceable postcode areunknown-postcode, PDOK unanswered, unsupported mode and provider, not linked, planner error, postcode normalisation.CatalogRegistryServiceTest: the three templates in their categories.application-registration-order.json(two new listener registrations) and theCatalogRegistrySeedGoldenTesthashes; the old hashes still match with the three new templates removed, so the change is only the additions.Suite
Unit suite before: 8493 tests, 2 errors, 3 failures (inherited). After: 8515 tests, 2 errors, 3 failures, the same ones.
Generated by Claude Code