Skip to content

feat(integriq): build intake-channels-beyond-mail - #3572

Merged
rubenvdlinde merged 4 commits into
developmentfrom
quality/build-intake-channels-beyond-mail
Nov 17, 2026
Merged

rubenvdlinde merged 4 commits into
developmentfrom
quality/build-intake-channels-beyond-mail

Conversation

@rubenvdlinde

Copy link
Copy Markdown
Contributor

Builds the open code tasks of openspec/changes/intake-channels-beyond-mail (Task 7, REQ-IC-021: a handler works a message from the shared inbox).

Tasks done

  • POST /api/intake/messages/{id}/assign (IntakeChannelsController::assign()), #[NoAdminRequired] behind the new ADR-023 action right intake.assign (seeded admin-only, like intake.reply). The handler id comes from the session, never from the request; the message is read and written as the handler.
  • IntakeAssignmentService: a held, routed or already assigned message gets status: assigned, targetRef (the case), assignedBy and assignedAt; a message in any other state, or an assign without a case, is refused and nothing is written.
  • IntakeMessageAssignedEvent: the app that owns the case is handed the message and its attachments and media; the answer says whether one took them in (attachmentsLinked). Integriq names no case type.
  • intake_message schema 1.2.0 (register 1.1.7): assignedBy, assignedAt, status assigned; inbox columns Case and Assigned by; OpenAPI document; en/nl strings.

Tasks left, and why

  • Task 7 row actions on the inbox (msg-shared-inbox, msg-reply-channel) and their Playwright test: the inbox is a type: logs page, which declares no row actions, and the app shell passes no ADR-023 action rights to the manifest, so the actions could not yet be hidden from a reader without the right (REQ-IC-021 scenario 3). Noted in tasks.md.
  • Task 6 coordination items (dossiq case.intakeChannel, the portaliq form definition): not code.
  • A listener in the app that owns cases for IntakeMessageAssignedEvent belongs to that app.

Tests added

  • IntakeAssignmentServiceTest (6 tests): assigning, the hand-off and its attachments, nobody taking it in, no case, each refused state, unknown message.
  • IntakeChannelsControllerAssignTest (5 tests): anonymous, missing right, the case and session user passed on, 404/400/503.
  • Updated IntakeBindingsTest and the registration-order fixture for the new binding.

Suite

  • Before (development): 8493 tests, 2 errors, 3 failures (CallServiceTest x2, JobsControllerTest x2, SynchronizationSynchronizeEntryGoldenTest).
  • After: 8504 tests, the same 2 errors and 3 failures, nothing new. phpstan clean on the touched lib files; maintainability floor holds; test:l10n, check:l10n-js, check:manifest OK; check:schema-l10n adds no uncovered strings.

Generated by Claude Code

A handler assigns a message from the shared intake inbox to a case
(REQ-IC-021): POST /api/intake/messages/{id}/assign behind the new
intake.assign action right. The message records the case, who assigned it
and when (intake_message 1.2.0, status assigned), and the app that owns the
case is handed the message and its attachments through
IntakeMessageAssignedEvent. The inbox shows the case and who assigned it.

Assisted-by: ClaudeCode:claude-opus-5-5
rubenvdlinde and others added 3 commits November 14, 2026 15:35
…p ci]

Keeps both sides: the assign endpoint and the rule test / route-again
endpoints in IntakeChannelsController and openapi.json, both l10n
blocks, and a label and area for intake.assign in the action seed.

Assisted-by: ClaudeCode:claude-opus-5-5
…p ci]

Resolve conflicts with development: keep both sides' l10n keys and both
sides' openapi.json paths (structural merge). IntakeAssignmentService now
finds and saves the intake message through openregister main's
ObjectFindOptions / ObjectSaveOptions API, as development's object
service stubs require; same register, schema and uuid.

Assisted-by: ClaudeCode:claude-opus-5-5
@rubenvdlinde
rubenvdlinde merged commit 975c9c9 into development Nov 17, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants