Skip to content

feat(integriq): build messaging-sms-providers-and-notifynl-mail - #3563

Merged
rubenvdlinde merged 1 commit into
developmentfrom
quality/build-messaging-sms-providers-and-notifynl-mail
Nov 14, 2026
Merged

rubenvdlinde merged 1 commit into
developmentfrom
quality/build-messaging-sms-providers-and-notifynl-mail

Conversation

@rubenvdlinde

Copy link
Copy Markdown
Contributor

Builds part of openspec/changes/messaging-sms-providers-and-notifynl-mail (result: partial).

Tasks done

  • 1: SmsProviderRegistry holds every SMS binding by provider id. SmsDispatchService::resolveProvider() asks it: no value is the log binding, and a value no binding answers to (for example twillio) resolves to UnknownSmsProvider, which refuses the send naming the value, so the message is stored failed with that reason instead of reported as sent.
  • 2 to 4: CmComSmsProvider, MessageBirdSmsProvider and TwilioSmsProvider on a shared BrokeredSmsProvider. Every call goes through BrokeredCallService::prepare() and dispatch() as the Mollie binding does, and nothing leaves without a credentialRef. MessageBird and Twilio read status from the vendor. CM.com has no status read, so its fetchStatus() refuses and says status arrives by callback.
  • 8: three demo sms_message rows, one per new provider, in the states sent, delivered and failed.

Tasks left

  • 5 (caller picks the source, provider picker, GET /api/sms/providers, sms_message.sourceSlug), 6 (vendor delivery callbacks) and 7 (NotifyNL e-mail) did not fit in this run.
  • Live sends per vendor and the e2e spec need accounts and a browser; not done.

Behaviour change

  • A source whose provider value is unknown used to fall back to the log binding and report every message as sent. Now each send fails, naming the value. The design asks for this.

Tests

  • 31 new unit tests: the three bindings against a stubbed broker, the registry against the real bindings, and the dispatcher's unknown-provider path. Each was seen failing on a broken subject line.
  • Unit suite on development: 8493 tests, 7 failing. On this branch: 8512 tests, 5 failing, all 5 also failing on development. phpcs and phpstan are clean on the touched files, and tests/validate-register.js passes.

Generated by Claude Code

… ci]

Adds the SMS provider registry, the CM.com, MessageBird and Twilio
bindings over the credential broker, and the refusal of an unknown
provider value, plus one demo message per new provider.

Assisted-by: ClaudeCode:claude-opus-5-5
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant