Skip to content

feat(integriq): build connectors-lti-platform-launch - #3545

Merged
rubenvdlinde merged 4 commits into
developmentfrom
quality/build-connectors-lti-platform-launch
Nov 17, 2026
Merged

rubenvdlinde merged 4 commits into
developmentfrom
quality/build-connectors-lti-platform-launch

Conversation

@rubenvdlinde

Copy link
Copy Markdown
Contributor

Builds what was left open in code for openspec/changes/connectors-lti-platform-launch.

Tasks done

  • Task 2: the launch page and error page strings (LtiPlatformController::authorize() / errorPage(), 12 strings) are now in l10n/en.json and l10n/nl.json; l10n/en.js and l10n/nl.js are rebuilt from them with scripts/build-l10n-js.js, so check:l10n-js stays clean.
  • Task 4: tests/validate-register.js run and passing with redirectUris on lti_tool (recorded in tasks.md).

Tasks left and why

  • Task 2 test: tests/e2e/lti-platform-launch.spec.ts and the reference tool fixture need a running instance.
  • Task 3 test: integration run against a live reference tool.
  • Task 4 test: the e2e half, same reason as Task 2.

Tests

  • No PHP changed. Unit suite before/after: 8222 tests, 3 failures + 2 errors, identical on development (inherited).
  • npm run test:l10n OK; test:l10n:parity was already failing on development; nl count unchanged, other locales stay absent for these keys.

Generated by Claude Code

Adds the LTI launch and error page strings to the backend catalogues
(en, nl) and rebuilds the browser catalogues from them.

Assisted-by: ClaudeCode:claude-opus-5-5
…skip ci]

Resolve l10n conflicts in en/nl js and json by keeping both sides' keys.

Assisted-by: ClaudeCode:claude-opus-5-5
…skip ci]

Resolve the l10n conflict: union of the en/nl .json catalogues; the .js catalogues stay as on development, as the twelve launch strings are read only by PHP.

Assisted-by: ClaudeCode
@rubenvdlinde
rubenvdlinde merged commit 6b2ea46 into development Nov 17, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant