Repository navigation
feat(integriq): build connectors-lti-platform-launch - #3545
Merged
rubenvdlinde merged 4 commits intoNov 17, 2026
Merged
Conversation
Adds the LTI launch and error page strings to the backend catalogues (en, nl) and rebuilds the browser catalogues from them. Assisted-by: ClaudeCode:claude-opus-5-5
rubenvdlinde
requested review from
Rem-Dam,
SudoThijn,
WilcoLouwerse,
bbrands02,
remko48 and
rjzondervan
as code owners
November 13, 2026 20:53
…-launch [skip ci]
…skip ci] Resolve l10n conflicts in en/nl js and json by keeping both sides' keys. Assisted-by: ClaudeCode:claude-opus-5-5
…skip ci] Resolve the l10n conflict: union of the en/nl .json catalogues; the .js catalogues stay as on development, as the twelve launch strings are read only by PHP. Assisted-by: ClaudeCode
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Builds what was left open in code for
openspec/changes/connectors-lti-platform-launch.Tasks done
LtiPlatformController::authorize()/errorPage(), 12 strings) are now inl10n/en.jsonandl10n/nl.json;l10n/en.jsandl10n/nl.jsare rebuilt from them withscripts/build-l10n-js.js, socheck:l10n-jsstays clean.tests/validate-register.jsrun and passing withredirectUrisonlti_tool(recorded in tasks.md).Tasks left and why
tests/e2e/lti-platform-launch.spec.tsand the reference tool fixture need a running instance.Tests
npm run test:l10nOK;test:l10n:paritywas already failing on development; nl count unchanged, other locales stay absent for these keys.Generated by Claude Code