Skip to content

chore: quote the stylelint globs, add .editorconfig - #1230

Merged
rubenvdlinde merged 1 commit into
developmentfrom
chore/editorconfig-and-stylelint-glob
Aug 12, 2026
Merged

rubenvdlinde merged 1 commit into
developmentfrom
chore/editorconfig-and-stylelint-glob

Conversation

@rubenvdlinde

@rubenvdlinde rubenvdlinde commented Aug 12, 2026 •

Copy link
Copy Markdown
Contributor

Two of the ten deviations gate-65 coding-standard-adoption reports. The other eight are a toolchain migration and are tracked in #1231.

The unquoted glob was hiding 89% of the files it claimed to check

"stylelint": "stylelint src/**/*.vue src/**/*.scss src/**/*.css"

The shell expands that before stylelint sees it, and without globstar — off by default in bash — src/**/ matches exactly one directory level.

Measured in this repo:

shell-expanded, as the script actually ran 8 .vue files
actually present under src/ 74 .vue files

So 66 files were never linted, and Vue Quality (stylelint) reported green over them. Quoting hands the pattern to stylelint, which expands it itself with real ** semantics.

⚠️ This widens the check from 8 files to 74. If any of the 66 that were never looked at have violations, Vue Quality (stylelint) will now say so. Those failures are pre-existing, not introduced here — and finding them is the point. If the job goes red, the right response is to fix the violations, not to re-narrow the glob.

.editorconfig

Nextcloud core ships one; without it an editor falls back to whatever the developer last configured, so the repo's indentation becomes a property of who opened it.

Values follow what the repo already contains — tabs in PHP/JS/Vue, two-space YAML/JSON. Markdown keeps its trailing whitespace, which is a hard line break there rather than untidiness.

Two of the ten deviations gate-65 (coding-standard-adoption) reports. The
other eight are a toolchain migration — adopt conduction/coding-standard, move
formatting to php-cs-fixer, centralise phpcs.xml — and are tracked separately.

THE UNQUOTED GLOB WAS HIDING 89% OF THE FILES IT CLAIMED TO CHECK.

    "stylelint": "stylelint src/**/*.vue src/**/*.scss src/**/*.css"

The shell expands that before stylelint sees it, and without `globstar` — which
is off by default in bash — `src/**/` matches exactly ONE directory level.
Measured in this repo:

    shell-expanded, as the script ran:   8 .vue files
    actually present under src/:        74 .vue files

So 66 files were never linted, and the check reported green over them. Quoting
hands the pattern to stylelint, which expands it itself with real `**`
semantics.

⚠️ This WIDENS the check from 8 files to 74. If any of the 66 that were never
looked at have violations, `Vue Quality (stylelint)` will now say so — that is
the point, and those failures are pre-existing rather than introduced here.

`.editorconfig` follows what the repo already contains: tabs in PHP/JS/Vue,
two-space YAML/JSON. Markdown keeps its trailing whitespace, which is a hard
line break there rather than untidiness.
@github-actions

Copy link
Copy Markdown
Contributor

Quality Report — ConductionNL/openconnector @ a33bd40

Check PHP Vue Security License Tests
lint ✅
phpcs ✅
phpmd ✅
psalm ✅
phpstan ✅
phpmetrics ✅
eslint ✅
stylelint ✅
build ✅
build ✅
check-specs ✅
test-l10n ✅
composer ✅ ✅ 152/152
npm ✅ ✅ 551/551
PHPUnit ✅
Newman ✅
Playwright ✅
Hydra gates ❌

Quality workflow — 2026-08-12 10:25 UTC

Download the full PDF report from the workflow artifacts.

@rubenvdlinde
rubenvdlinde merged commit 03f1a92 into development Aug 12, 2026
32 of 34 checks passed
@rubenvdlinde
rubenvdlinde deleted the chore/editorconfig-and-stylelint-glob branch August 12, 2026 10:25
rubenvdlinde added a commit that referenced this pull request Aug 12, 2026
Conflicts and how they were resolved:

- .editorconfig: both sides added one. Kept the Nextcloud core file the
  coding-standard migration ships (it is the fleet-wide artefact) and folded
  in the two stanzas development's version had that it did not cover:
  [*.{yml,yaml,json,jsonc}] instead of the narrower [*.yml], and [Makefile].
  No setting differs between the two — only coverage.

- package.json: both sides quoted the stylelint glob. Took development's
  three-glob form (#1230); the brace form on this branch is equivalent, and
  keeping the base's spelling leaves this PR with no diff on the line.

- appinfo/info.xml: development (#1224) added an <install> repair-steps hook
  and MigrateLegacyStorage; this branch had moved <repair-steps> and
  <settings> to their App Store xs:sequence positions. Applied development's
  content at this branch's element positions, so the fresh-install fix and
  the ordering fix both survive. Parsed back to confirm the XML is valid.

- lib/Migration/Version2Date20260520000099.php and
  lib/Service/Migration/LegacyToRegisterMigrator.php: the reformat rewrote
  every brace in both files while development (#1224) swapped
  fetchAssociative()/fetchAllAssociative() for fetchOne()/fetch()/fetchAll()
  because the Associative variants only reached OCP\DB\IResult in NC 33 and
  this app advertises min-version 32. Took the reformatted files and
  re-applied all seven of development's call-site changes, including the
  guarded `$count === false` branch, by hand.

lib/Repair/MigrateLegacyStorage.php and its test arrived from development in
the old Allman style, so php-cs-fixer was re-run over the whole tree: it
reformatted exactly those two files, and the re-check reports
"Found 0 of 713 files that can be fixed".

composer.lock did not conflict — development has not touched it since the
merge base — and still resolves nextcloud/ocp to v34.0.2. composer validate
passes, so the lock's content-hash still matches composer.json.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant