Repository navigation
chore: quote the stylelint globs, add .editorconfig - #1230
Merged
Merged
Conversation
Two of the ten deviations gate-65 (coding-standard-adoption) reports. The
other eight are a toolchain migration — adopt conduction/coding-standard, move
formatting to php-cs-fixer, centralise phpcs.xml — and are tracked separately.
THE UNQUOTED GLOB WAS HIDING 89% OF THE FILES IT CLAIMED TO CHECK.
"stylelint": "stylelint src/**/*.vue src/**/*.scss src/**/*.css"
The shell expands that before stylelint sees it, and without `globstar` — which
is off by default in bash — `src/**/` matches exactly ONE directory level.
Measured in this repo:
shell-expanded, as the script ran: 8 .vue files
actually present under src/: 74 .vue files
So 66 files were never linted, and the check reported green over them. Quoting
hands the pattern to stylelint, which expands it itself with real `**`
semantics.
⚠️ This WIDENS the check from 8 files to 74. If any of the 66 that were never
looked at have violations, `Vue Quality (stylelint)` will now say so — that is
the point, and those failures are pre-existing rather than introduced here.
`.editorconfig` follows what the repo already contains: tabs in PHP/JS/Vue,
two-space YAML/JSON. Markdown keeps its trailing whitespace, which is a hard
line break there rather than untidiness.
rubenvdlinde
requested review from
Rem-Dam,
SudoThijn,
WilcoLouwerse,
bbrands02,
remko48 and
rjzondervan
as code owners
August 12, 2026 10:03
Contributor
Quality Report — ConductionNL/openconnector @
|
| Check | PHP | Vue | Security | License | Tests |
|---|---|---|---|---|---|
| lint | ✅ | ||||
| phpcs | ✅ | ||||
| phpmd | ✅ | ||||
| psalm | ✅ | ||||
| phpstan | ✅ | ||||
| phpmetrics | ✅ | ||||
| eslint | ✅ | ||||
| stylelint | ✅ | ||||
| build | ✅ | ||||
| build | ✅ | ||||
| check-specs | ✅ | ||||
| test-l10n | ✅ | ||||
| composer | ✅ | ✅ 152/152 | |||
| npm | ✅ | ✅ 551/551 | |||
| PHPUnit | ✅ | ||||
| Newman | ✅ | ||||
| Playwright | ✅ | ||||
| Hydra gates | ❌ |
Quality workflow — 2026-08-12 10:25 UTC
Download the full PDF report from the workflow artifacts.
rubenvdlinde
added a commit
that referenced
this pull request
Aug 12, 2026
Conflicts and how they were resolved:
- .editorconfig: both sides added one. Kept the Nextcloud core file the
coding-standard migration ships (it is the fleet-wide artefact) and folded
in the two stanzas development's version had that it did not cover:
[*.{yml,yaml,json,jsonc}] instead of the narrower [*.yml], and [Makefile].
No setting differs between the two — only coverage.
- package.json: both sides quoted the stylelint glob. Took development's
three-glob form (#1230); the brace form on this branch is equivalent, and
keeping the base's spelling leaves this PR with no diff on the line.
- appinfo/info.xml: development (#1224) added an <install> repair-steps hook
and MigrateLegacyStorage; this branch had moved <repair-steps> and
<settings> to their App Store xs:sequence positions. Applied development's
content at this branch's element positions, so the fresh-install fix and
the ordering fix both survive. Parsed back to confirm the XML is valid.
- lib/Migration/Version2Date20260520000099.php and
lib/Service/Migration/LegacyToRegisterMigrator.php: the reformat rewrote
every brace in both files while development (#1224) swapped
fetchAssociative()/fetchAllAssociative() for fetchOne()/fetch()/fetchAll()
because the Associative variants only reached OCP\DB\IResult in NC 33 and
this app advertises min-version 32. Took the reformatted files and
re-applied all seven of development's call-site changes, including the
guarded `$count === false` branch, by hand.
lib/Repair/MigrateLegacyStorage.php and its test arrived from development in
the old Allman style, so php-cs-fixer was re-run over the whole tree: it
reformatted exactly those two files, and the re-check reports
"Found 0 of 713 files that can be fixed".
composer.lock did not conflict — development has not touched it since the
merge base — and still resolves nextcloud/ocp to v34.0.2. composer validate
passes, so the lock's content-hash still matches composer.json.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two of the ten deviations
gate-65 coding-standard-adoptionreports. The other eight are a toolchain migration and are tracked in #1231.The unquoted glob was hiding 89% of the files it claimed to check
The shell expands that before stylelint sees it, and without
globstar— off by default in bash —src/**/matches exactly one directory level.Measured in this repo:
.vuefilessrc/.vuefilesSo 66 files were never linted, and
Vue Quality (stylelint)reported green over them. Quoting hands the pattern to stylelint, which expands it itself with real**semantics..editorconfigNextcloud core ships one; without it an editor falls back to whatever the developer last configured, so the repo's indentation becomes a property of who opened it.
Values follow what the repo already contains — tabs in PHP/JS/Vue, two-space YAML/JSON. Markdown keeps its trailing whitespace, which is a hard line break there rather than untidiness.