Repository navigation
chore(ci): stop pinning hydra-gates — track the package at @main - #1159
Merged
Merged
Conversation
A pinned `hydra-gates-ref` is a silent expiry date on every upstream fix: this repo cannot receive a gate-package change until this line moves. v1.4.0 is the latest tag and the first one that carries `hydra-gates/scripts/axe-run.cjs` (verified absent at v1.3.0), so it is also the first that has ConductionNL/.github#168 axe DOM scoping and ConductionNL/.github#165 gate-46 fix. `enable-axe` is deliberately NOT enabled in this commit. Ordering matters: the ref lands first, enabling axe is a separate decision.
rubenvdlinde
requested review from
Rem-Dam,
SudoThijn,
WilcoLouwerse,
bbrands02,
remko48 and
rjzondervan
as code owners
August 5, 2026 21:47
Contributor
Quality Report — ConductionNL/openconnector @
|
| Check | PHP | Vue | Security | License | Tests |
|---|---|---|---|---|---|
| lint | ✅ | ||||
| phpcs | ✅ | ||||
| phpmd | ✅ | ||||
| psalm | ✅ | ||||
| phpstan | ✅ | ||||
| phpmetrics | ✅ | ||||
| eslint | ✅ | ||||
| stylelint | ✅ | ||||
| build | ✅ | ||||
| build | ✅ | ||||
| check-specs | ✅ | ||||
| test-l10n | ✅ | ||||
| composer | ✅ | ✅ 153/153 | |||
| npm | ✅ | ✅ 692/692 | |||
| PHPUnit | ✅ | ||||
| Newman | ✅ | ||||
| Playwright | ✅ | ||||
| Hydra gates | ✅ |
Quality workflow — 2026-08-05 22:04 UTC
Download the full PDF report from the workflow artifacts.
Removes `hydra-gates-ref` entirely instead of moving it v1.3.0 -> v1.4.0. The shared workflow already defaults the input to @main, and this repo consumes `ConductionNL/.github/.github/workflows/quality.yml@main`, so both sides now move together: a gate-package fix reaches this repo with no commit here. A pin is a silent expiry date. 22 repos sat on v1.0.1 while 16 gates were dead fleet-wide and every one of them reported PASS (.github#159), and a default flipped at @main later reached those same old runners and failed them on gates they had no subject matter for (.github#173). Bumping the pin is a treadmill that reintroduces the same failure mode on the next release. The pin-justifying comment block is replaced with a short note saying why there is no ref here and how to reintroduce one deliberately. The rationale for `enable-hydra-gates: true` is kept, as is `enable-axe` being left off and this repo's explicit `hydra-gates-require-full-coverage: false`.
Contributor
Quality Report — ConductionNL/openconnector @
|
| Check | PHP | Vue | Security | License | Tests |
|---|---|---|---|---|---|
| lint | ✅ | ||||
| phpcs | ✅ | ||||
| phpmd | ✅ | ||||
| psalm | ✅ | ||||
| phpstan | ✅ | ||||
| phpmetrics | ✅ | ||||
| eslint | ✅ | ||||
| stylelint | ✅ | ||||
| build | ✅ | ||||
| build | ✅ | ||||
| check-specs | ✅ | ||||
| test-l10n | ✅ | ||||
| composer | ✅ | ✅ 153/153 | |||
| npm | ✅ | ✅ 692/692 | |||
| PHPUnit | ✅ | ||||
| Newman | ✅ | ||||
| Playwright | ✅ | ||||
| Hydra gates | ✅ |
Quality workflow — 2026-08-06 06:05 UTC
Download the full PDF report from the workflow artifacts.
…is failing this repo now development moved the pin to v1.5.0 while this branch removes it. Resolved in favour of removing it: a pin is what broke, and v1.5.0 is not a better pin. Since this branch was opened, the pinned-package-vs-floating-@main desync produced its most acute form yet. quality.yml@main now executes three gate helpers BY NAME — check_spec_anchors.py, check_form_labels.py and check_license_triangle.py — and NO tag before v1.5.0 contains any of them, so the Hydra Gates job here fails at "Verify the pinned gates package satisfies this workflow", before a single gate runs, with the workflow's own message: "This is NOT a code-quality finding about your repository." Verified by DIRECTORY LISTING of each tag rather than per-file lookups. Those answered "present" UNIFORMLY across v1.0.0..v1.5.0 — and uniformity across independent inputs is a statement about the instrument, not the inputs. The listing gives 0 of 3 at every tag through v1.4.0 and 3 of 3 at v1.5.0. Unpinning also picks up .github#179 (v1.5.1): on a push to `development`, `origin/development` IS `HEAD`, so the diff was empty by construction — <= v1.4.0 passed over it (permanently green) and v1.5.0 refused with exit 99 (permanently red). The scope is now `github.event.before...HEAD`, what the push actually changed, with exit 99 kept only for the cases that genuinely cannot be scoped.
Contributor
Quality Report — ConductionNL/openconnector @
|
| Check | PHP | Vue | Security | License | Tests |
|---|---|---|---|---|---|
| lint | ✅ | ||||
| phpcs | ✅ | ||||
| phpmd | ✅ | ||||
| psalm | ✅ | ||||
| phpstan | ✅ | ||||
| phpmetrics | ✅ | ||||
| eslint | ✅ | ||||
| stylelint | ✅ | ||||
| build | ✅ | ||||
| build | ✅ | ||||
| check-specs | ✅ | ||||
| test-l10n | ✅ | ||||
| composer | ✅ | ✅ 153/153 | |||
| npm | ✅ | ✅ 692/692 | |||
| PHPUnit | ✅ | ||||
| Newman | ✅ | ||||
| Playwright | ✅ | ||||
| Hydra gates | ✅ |
Quality workflow — 2026-08-06 06:41 UTC
Download the full PDF report from the workflow artifacts.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
This PR started life as a pin bump (
hydra-gates-ref: v1.3.0 -> v1.4.0). It now removes thehydra-gates-refline entirely so this caller inherits the shared workflow's default.enable-hydra-gates: true - hydra-gates-ref: v1.4.0enable-hydra-gates: trueis unchanged.enable-axeremains unset. The comment block that justified the pin is replaced with a short note explaining why there is deliberately no pin.Why
ConductionNL/.github/.github/workflows/quality.ymlalready defaultshydra-gates-reftomain, and this repo consumesquality.ymlat@main. Overriding the input was the only thing holding the gates package still. Drop the override and both sides move together — a gate fix reaches this repo without a commit in this repo.Bumping the pin is a treadmill: it works until the next fix lands upstream, and between bumps the repo is running whatever the gates package looked like on the day someone last remembered.
A pin is a silent expiry date on every upstream fix. We have paid for that twice:
v1.0.1, which predated the gate fixes. 16 gates were dead fleet-wide and every one of them reported PASS. A gate that never runs emits a tick identical to one that did, so nothing in any repo's CI history showed it.@mainwhile the package stayed pinned per caller. Old pinned runners did not carry the coverage accounting the new default assumed, so they went red on gates they had no subject matter for.The two failures are opposite shapes of the same split: shared workflow at
@main, package pinned. Removing the pin closes both.Rollback
ConductionNL/.githubmain. One commit reaches the whole fleet — which is the point.hydra-gates-ref:explicitly again, with a comment saying why this repo needs to hold still. The input is still honoured; it just is not the default posture.Safety net
ConductionNL/.github#177adds the resolve probe plus the gates package suite gating.githubmain, so a broken package cannot reachmainunnoticed now that consumers track it.