Skip to content

LTI Tool-role score publish is implemented, spec'd and tested — and unreachable #1176

Open

Description

@rubenvdlinde

LtiAgsService::publishScore() is fully implemented, spec'd against REQ-LTI-008, and unit-tested — and nothing in production calls it. Raised by gate-57 (orphaned-write-capability).

What is wired, and what is not

The lti#agsScore route exists, but that is the Platform-role inbound direction: openconnector receiving a score POST from a Tool.

publishScore() is the Tool-role outbound direction: openconnector authenticating to a remote Platform with the JWT-bearer client-credentials grant and POSTing a score to that Platform's line item. There is no route, no job, no flow step and no action that reaches it. Its only callers are tests/Unit/Service/Lti/LtiAgsServiceTest.php.

$ grep -rn "publishScore" lib/ src/ appinfo/
lib/Service/Lti/LtiAgsService.php:393    (the definition)

Why this is not a cleanup

The code looks correct and the spec asks for it. What is missing is the decision about how a score publish gets triggered — an admin action on a deployment, a background job reading pending results, a flow step, or an endpoint another app calls. That is a design choice about the Tool-role lifecycle, not something to pick by whichever wiring is easiest.

The same question probably applies to the sibling result-read path in REQ-LTI-008 and to the NRPS outbound direction in REQ-LTI-009 — worth checking together rather than one at a time.

Meanwhile

gate-57 stays red on this repo for exactly this one finding. It is the honest state: the capability ships, and no user can reach it.

Found while clearing gate debt on development (#1175).

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't working

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions