Repository navigation
feat(filinq): build image-redaction - #2191
Open
rubenvdlinde wants to merge 10 commits into
Open
rubenvdlinde wants to merge 10 commits into
rubenvdlinde wants to merge 10 commits into
Conversation
Scope decisions: a page, a page range or a whole document redacted in one action. ScopeRedactionService validates a decision (pages within the document, a range that does not run backwards, at least one ground), stores it on the document's review, and commits it: pages as full-page regions on OpenRegister's image seam, a whole document withheld with no output. Publication readiness lists a withheld document as not for publication. Register 8.72.0: additive anonymizationLink and documentReview fields. Assisted-by: ClaudeCode:claude-opus-5-5
rubenvdlinde
requested review from
Rem-Dam,
SudoThijn,
WilcoLouwerse,
bbrands02,
remko48 and
rjzondervan
as code owners
November 17, 2026 15:15
Fail-flagged image leg (task 3.3): extract flags an image-bearing file the seam could not look at (imageDetectionSkipped with the reason) and attaches found regions to their entity rows as origin image with boxes; an anonymise that did not burn image content carries imageRedactionPending, and burnedRegionCount counts only regions the seam burned, on the result and on the link. Assisted-by: ClaudeCode:claude-opus-5-5
Workbench: one action redacts a page, a range of pages or the whole document (ScopeRedactionDialog under src/dialogs, grounds through the same picker as the entity review), and each decision shows as a row. SIGNATURE joins the entity types; the review warns when images were not checked, when no signature detector ran, and when an anonymised copy still has unredacted images. EN and NL strings; browser catalogues rebuilt. Assisted-by: ClaudeCode:claude-opus-5-5
Playwright spec tests/e2e/spec-coverage/image-redaction.spec.ts for the @e2e scenarios (scope dialog, refusals, a sessionless caller, the image warnings, the burn), docs/features/image-redaction.md, and the scanned Demostad sample letter with a printed BSN and a signature block. Assisted-by: ClaudeCode:claude-opus-5-5
The controller talks only to ScopeRedactionService, which now reads the state and counts pages itself; the refusal lives beside it. Register property descriptions, app version raised for the register change, @SPEC tags on the new frontend methods. Assisted-by: ClaudeCode:claude-opus-5-5
Task 3.2: the image seam runs before the entity read-back, so the regions it stores take the same proposals, policy matches and risk as a text finding; found regions are attached to those rows as origin image with boxes. Assisted-by: ClaudeCode:claude-opus-5-5
Register v8.73.0 keeps both lines' schemas; app version bumped past both. Assisted-by: ClaudeCode:claude-opus-5-5
Task 4.1: the review workbench draws the image-origin entity rows as region overlays on the PDF preview pages. The overlays come from the same entity rows as the table (regionOverlays), so a rejected row shows as a region kept visible and every other row as a region to be redacted; a box that cannot be placed is left out and the row stays in the table. Assisted-by: ClaudeCode:claude-opus-5-5
Contributor
Author
|
Continuation pushed (9ef3990): task 4.1 is built. The review workbench now draws the image-origin entity rows as region overlays on the PDF preview pages. The overlays come from the same entity rows as the table, so a rejected row shows as a region kept visible and every other row as a region to be redacted. A box that cannot be placed is left out, and its row stays in the table. Tests: Generated by Claude Code |
…ip ci] Restores the unit complexity rating the merge gate holds (4.51 to 4.52); no behaviour change, unit suite and vitest green. Assisted-by: ClaudeCode:claude-opus-5-5
Assisted-by: ClaudeCode:claude-opus-5-5
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Builds
openspec/changes/image-redaction(round 2): page, page-range and whole-document redaction in one action (Woo row 4.24), the fail-flagged image leg around OpenRegister's image seam, and the workbench UI.Tasks done (ticked in tasks.md)
anonymizationLink1.5.0:burnedRegionCount,imageRedactionPending, pluswithheld,withheldBases, statuswithheld;anonymizedFileIdno longer required (a withheld document has no output). Register 8.72.0, app version raised.tests/sample-documents/parkeervergunning-demostad-scan.png: scanned Demostad letter with a printed (test) BSN and a signature block.origin: image+boxes(additive).imageDetectionSkipped(backend_unavailable/not_detectedwith the seam's reason) on extract,objectDetectionpassed through;imageRedactionPending+burnedRegionCount(performed burns only) on the anonymise result and on its link.tests/e2e/spec-coverage/image-redaction.spec.tsfor every@e2escenario (base URL from env, a sessionless context with an empty storage state). Not run here: no Nextcloud instance in this session.ScopeRedactionServicevalidates (pages within the document, ranges forward, at least one ground) and stores a decision ondocumentReview.scopeDecisions(1.1.0).Built, left unticked, and why
box0,0,1,1) onImageRedactionService::redactImage(); whole document is withheld with no output;PublicationReadinesslists a withheld document as not for publication; no seam refuses with nothing written. Seam methods on openregister main: regions are persisted byImageRedactionService::detectImage()(EntityRelationpage/box) and burned byImageRedactionService::redactImage(). Precondition unmet:redactImage()refuses PDFs ("burning image content inside application/pdf files is not supported yet"; openregisteranonymisation-image-seamtask 3.2 is open), so a page scope on a PDF is refused with nothing written. No burner was written in filinq. The per-page notice naming the ground has no place in the seam's region yet. An openregister issue needs filing for both (this worker may not open issues).src/dialogs/ScopeRedactionDialog.vue, the toolbar button in the review sidebar and the decision rows are built and lint/jest-tested; not browser-verified.docs/features/image-redaction.mdwritten (three scopes, why a withheld document has no output, OpenRegister does the pixel work); docs build and Playwright screenshots not run here.Not built
detectImage/redactImageexist on main; theSIGNATUREconstant andsupportsImages/supportsSignaturesflags do not.anonymizeDocumentalready; PDFs wait on the same seam task.openspec validate(no openspec CLI here).Tests
testARangeBeyondTheLastPageIsRefusedondevelopment:Tests: 1, Assertions: 0, Errors: 1.(the class does not exist); passes here.PublicationReadinessTest::testAWithheldDocumentIsNotForPublication, PublicationStoreTest additions; jestimageRedaction.spec.js(13).imageWarning: null).--base origin/development: sig floor met; 8 failures remain, all in files this PR does not touch (composer-audit, no-admin-idor, spec-anchor-existence, controller-exception-translation, relation-dialect, orphaned-write-capability, icon-vocabulary, cross-app-schema-slug).Generated by Claude Code