Repository navigation
feat(filinq): build office-charts-and-images - #2188
Open
rubenvdlinde wants to merge 2 commits into
Open
rubenvdlinde wants to merge 2 commits into
rubenvdlinde wants to merge 2 commits into
Conversation
Office chart and image fillers for ${chart:key} and ${image:key}, a
fixture DOCX, unit tests and the office section of the template-charts
docs. The fillers are called from the office render path once
office-template-authoring 2.3 lands.
Assisted-by: ClaudeCode:claude-opus-5-5
rubenvdlinde
requested review from
Rem-Dam,
SudoThijn,
WilcoLouwerse,
bbrands02,
remko48 and
rjzondervan
as code owners
November 17, 2026 15:09
…skip ci] REQ-DDTCH-003 and REQ-DDTCH-008 live in the office-charts-and-images delta until it is archived, not yet in openspec/specs/template-charts/spec.md. Assisted-by: ClaudeCode:claude-opus-5-5
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Builds
openspec/changes/office-charts-and-images.Tasks done
OfficeChartFiller:${chart:key}becomes a native Word chart (bar → column, horizontal bar → bar, line, pie) viaTemplateProcessor::setChart(), built fromcharts.key = {type, data, options}and validated by the sharedChartDataNormalizer. Bad or missing context leaves the[chart error: …]marker and a warning; the 20-charts cap matches the Twig path.OfficeImageFiller:${image:key}readsimages.key(a file id, or{fileId, width, height}) throughTemplateImageResolveras the generating user and places it withsetImageValue()at the declared size. Unreadable files and WebP (not placeable in DOCX) leave the[image unavailable: …]marker and a warning.tests/sample-documents/chart-template.docxwith${chart:bezwaren},${image:logo}, a row-cloning table and a block.docs/features/template-charts.md.Tasks left
Tests
tests/unit/Service/OfficeTemplateChartTest.php(6 tests, incl.testSetChartCapabilityPinned) andtests/unit/Service/OfficeTemplateImageTest.php(5 tests).Generated by Claude Code