Repository navigation
feat(filinq): build diwoo-documentsoort-to-opencatalogi - #2187
Open
rubenvdlinde wants to merge 1 commit into
Open
rubenvdlinde wants to merge 1 commit into
rubenvdlinde wants to merge 1 commit into
Conversation
The hand-off writes the DiWoo document type to OpenCatalogi's own documentsoort field and never to summary, refuses the hand-off when OpenCatalogi's publication schema does not declare the field, and pins the field map against opencatalogi development e05ae03ce. Assisted-by: ClaudeCode:claude-opus-5-5
rubenvdlinde
requested review from
Rem-Dam,
SudoThijn,
WilcoLouwerse,
bbrands02,
remko48 and
rjzondervan
as code owners
November 17, 2026 15:08
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Builds
openspec/changes/diwoo-documentsoort-to-opencatalogi. It is paired with opencatalogidiwoo-metadata-on-the-publication, which is now merged on opencatalogi development.Tasks done
OpenCatalogiPublicationMap::FIELDSgainsdocumentsoort.toPublication()writes the record's document type there and never writessummary. The class docblock no longer says the publication has no document type field.OpenCatalogiPlatform::publicationDeclares()reads thepublicationschema of OpenCatalogi'spublicationregister through OpenRegister'sRegisterMapper::find()andSchemaMapper::findBySlugInIds(), using main's signatures. It fails closed. Before it reads the copy or writes anything,PublicationPipelineService::handoff()refuses with a 409 that names the OpenCatalogi update it needs. The record staysready. A document type that OpenCatalogi refuses (aHookStoppedExceptionfrom its pre-save listener) reaches the operator through the existing error path, and the record staysreadywith nohanded_offentry.tests/fixtures/opencatalogi-publication-schema.jsonwas refreshed from opencatalogi development e05ae03ce:publication_register.jsonplus itsregister.dfragments, deep-merged in filename order the waySettingsServicedoes it, schemapublication0.0.8, 39 properties. The existing pin testtestTheFieldMapMatchesOpenCataloginow coversdocumentsoort, and the payload test validates the new payload against the refreshed schema._rbac: falseread inOpenCatalogiPlatformis recorded indocs/authorization-decisions.mdandRECORDED_BYPASSES. It returns a yes or no only and runs afterPublicationAccess.Tasks left, and why
documentsoorton the OpenCatalogi publication needs a live instance with OpenCatalogi.woo-publicatie-pipeline.spec.tsanswers the API with route handlers. The docs part of 4 is done.Fails on development first
OpenCatalogiPublicationMapTest::testTheDocumentTypeGoesToItsOwnFieldfails on development withFailed asserting that two arrays are identical(development writes'summary' => 'besluit'and nodocumentsoort).PublicationPipelineServiceTest::testAnOpenCatalogiWithoutTheFieldRefusesTheHandoffand::testTheHandOffWritesTheDocumentTypeToItsOwnFieldalso fail on development.Payload this change produces (for opencatalogi's
DiwooCompletenessListenerTest::testTheFilinqHandoffPayloadIsAccepted){"title": "Besluit 2025-017", "documentsoort": "besluit", "wooCategory": "infocat009", "publicationDate": "2026-09-29T00:00:00+00:00"}Tests added
OpenCatalogiPublicationMapTest: 3 tests.PublicationPipelineServiceTest:testTheHandOffWritesTheDocumentTypeToItsOwnField,testAnOpenCatalogiWithoutTheFieldRefusesTheHandoffandtestARefusedDocumentTypeLeavesTheRecordReady, with mapper doubles shaped like OpenRegister main's.HookStoppedExceptionstub that mirrors OpenRegister main.Suite before/after
Generated by Claude Code