Skip to content

feat(filinq): build finish-half-built-capabilities - #2130

Open
rubenvdlinde wants to merge 12 commits into
developmentfrom
quality/build-finish-half-built-capabilities
Open

rubenvdlinde wants to merge 12 commits into
developmentfrom
quality/build-finish-half-built-capabilities

Conversation

@rubenvdlinde

Copy link
Copy Markdown
Contributor

Continues finish-half-built-capabilities after #2068 merged (this branch carries the work pushed after that merge, with development merged in).

Tasks done

  • 2.1 Woo consent request sent by email or letter, and recorded (ConsentRequestSender, publicationConsent 1.6.0 gains notificationChannel / notificationError; register 8.56.0). 7 tests.
  • 1.1 OCR text layer: after a run, a scanned PDF gets the recognised words as an invisible text layer in a new version of the same file (pages imported unchanged, the file before the run stays in its version history); a JPEG or PNG gets a searchable PDF beside it. A layer that cannot be made is reported on the run's outcome (textLayer), never thrown, and is skipped when the person may not change the file. New: OcrPage, InvisibleTextPdf, SearchablePdfWriter, PdfPageRasterizer, OcrTextLayerService, TesseractCommand::words(). 12 tests.
  • 3.2 Admin settings section DocumentFinalityRuleSettings as the caller of POST /api/document-finality-rules; en + nl strings. 4 jest tests; settings golden re-recorded (adds the section only).

Left, and why

  • 3.2's Playwright check (declare a rule, a status change makes the document final) needs a live instance.
  • 1.1 relies on the Imagick extension to render PDF pages and on FPDI reading the PDF; a PDF FPDI cannot read (e.g. compressed cross-reference streams) is skipped as failed, logged.

Tests

  • PHPUnit (phpunit-unit.xml): development 6736 tests OK (6 skipped) → branch 6755 OK (6 skipped), no new failures.
  • jest: 524 passed. vitest: 751 passed. eslint: no errors on touched files. phpcs/phpstan clean on touched PHP.

Generated by Claude Code

Task 2.1 (REQ-FHB-02): a new consent request waiting on the third party
is sent to it, by email through Nextcloud's mailer when an email address
is known, otherwise as a letter from the correspondence composer's
configured consent template. The record keeps the channel, the moment it
was sent and the objection deadline counted from then; a request that
cannot be sent stays open with the reason. publicationConsent gains
notificationChannel, notificationSentAt and notificationError (register
8.55.0).

Assisted-by: ClaudeCode:claude-opus-5-5
… [skip ci]

Assisted-by: ClaudeCode:claude-opus-5-5
Task 1.1: after an OCR run the recognised words are written back as an
invisible text layer. A scanned PDF keeps its pages (imported as they
are) and gets the layer as a new version of the same file, so the file
before the run stays in its version history; a JPEG or PNG gets a
searchable PDF beside it. A layer that cannot be made is reported on the
run's outcome, never thrown.

Assisted-by: ClaudeCode:claude-opus-5-5
Task 3.2: an admin settings section declares which states of a
consuming app's record make its documents final, through
POST /api/document-finality-rules (the server keeps checking the
final-document administrator right). English and Dutch strings.

Assisted-by: ClaudeCode:claude-opus-5-5
rubenvdlinde and others added 6 commits November 14, 2026 16:54
…skip ci]

Keep both new admin sections (finality rules from this change, document
webhooks from development) in Settings.vue, regenerate the settings
page golden, and keep both sides' en/nl strings.

Assisted-by: ClaudeCode:claude-opus-5-5
…skip ci]

Keep both sides: register v8.64.0 carries both lines' entries, the
settings page shows the finality rules beside bridge sources and
detection providers, the bootstrap keeps both autoloaders, l10n merged
key by key and the .js catalogues rebuilt, settings golden re-recorded.

Assisted-by: ClaudeCode:claude-opus-5-5
OcrTextLayerService wrote the searchable PDF over the file with putContent(),
outside the guard every edit session goes through. The automatic extraction
fallback therefore rewrote final (frozen) PDFs, whose frozen checksum then
stopped matching, and would do the same to a PDF under signature.

Before rewriting a PDF in place, the text layer now asks DocumentGuard the
refusals an edit gets (final, under signature, source of an anonymised copy)
and reports `protected` when one applies. An image is only given a new PDF
beside it, so it is not guarded. The spec delta records the scenario.

Assisted-by: ClaudeCode:claude-opus-5-5
… end [skip ci]

The Playwright check task 3.2 names: the admin fills the Final documents
by record state section, the stored rule is trimmed and deduplicated,
and the owning app's status report then freezes the document, read on
its Versions tab.

Assisted-by: ClaudeCode:claude-opus-5-5
…skip ci]

Conflicts resolved keeping both sides: the l10n catalogues as the union of
both (development's Dutch value where both had the key), the .js rebuilt
from the .json; the register at v8.73.0 with this line's entry ahead of
development's history; the unit bootstrap with development's explicit OCP
list and this line's general OCP autoloader after it.

Assisted-by: ClaudeCode:claude-opus-5-5

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants