Repository navigation
feat(dossiq): build generated-document-names-its-template-version - #6668
Open
rubenvdlinde wants to merge 1 commit into
Open
rubenvdlinde wants to merge 1 commit into
rubenvdlinde wants to merge 1 commit into
Conversation
…ip ci] The dossiq side of filinq's generated-document-names-its-template-version (task 7.2): resolveVersion() asks filinq's versionInForceAt() for the end of the effective date instead of walking the version chain itself, and the composition takes the sha256 and pageCount filinq reports, so countPages() and its regular expression over the PDF are gone. Assisted-by: ClaudeCode:claude-opus-5-5
rubenvdlinde
requested review from
Rem-Dam,
SudoThijn,
WilcoLouwerse,
bbrands02,
remko48 and
rjzondervan
as code owners
November 17, 2026 15:09
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The dossiq counterpart of filinq's
openspec/changes/generated-document-names-its-template-version, task 7.2: "pointFilinqTemplateEngineAdapter::resolveVersion()at the new query and deletecountPages()".Changes
resolveVersion()asks filinq'sTemplateVersionService::versionInForceAt()which version was the head of the template at the end of the effective date (23:59:59). The adapter's own walk over the version chain (versionTag(),highestVersionAtOrBefore(),VERSION_PAGE_SIZE) is removed. That walk read the snapshot's creation time as the moment its version started. In filinq, a snapshot is written when its version is replaced, so filinq's query is the one that knows the answer.@selfversion is used. With neither, the request is refused;v1is never assumed.sha256andpageCountfrom filinq's generation result.countPages()and its regular expression over the PDF are deleted. When filinq reports no well-formed digest, the returned bytes are hashed. When it reports no page count, the count is 0.Tests
FilinqTemplateEngineAdapterTest: the chain double now answersversionInForceAt(). Two tests are new or rewritten: the query is asked for the end of the effective date, and a failing query falls back to the template's own version. Composition tests cover the reported digest and page count, and the fallback to the bytes. Four of the tests fail against the old adapter.catch-return-null.allowlist.json: the reason names the new warning.phpunit-unit.xml): before 18398 tests, after 18399. The same 16 failures occur in both runs (CaseTypeRightsEnforcedAccessTest,CaseTypeRuleProjectorTest,StatusEntryRequirementsGuardTest), so they are inherited fromdevelopment.Generated by Claude Code