Skip to content

feat(dossiq): build generated-document-names-its-template-version - #6668

Open
rubenvdlinde wants to merge 1 commit into
developmentfrom
quality/build-generated-document-names-its-template-version
Open

rubenvdlinde wants to merge 1 commit into
developmentfrom
quality/build-generated-document-names-its-template-version

Conversation

@rubenvdlinde

Copy link
Copy Markdown
Contributor

The dossiq counterpart of filinq's openspec/changes/generated-document-names-its-template-version, task 7.2: "point FilinqTemplateEngineAdapter::resolveVersion() at the new query and delete countPages()".

Changes

  • resolveVersion() asks filinq's TemplateVersionService::versionInForceAt() which version was the head of the template at the end of the effective date (23:59:59). The adapter's own walk over the version chain (versionTag(), highestVersionAtOrBefore(), VERSION_PAGE_SIZE) is removed. That walk read the snapshot's creation time as the moment its version started. In filinq, a snapshot is written when its version is replaced, so filinq's query is the one that knows the answer.
  • The fallbacks are unchanged: when filinq names no version (no query, or it throws), the template's own @self version is used. With neither, the request is refused; v1 is never assumed.
  • The composition takes sha256 and pageCount from filinq's generation result. countPages() and its regular expression over the PDF are deleted. When filinq reports no well-formed digest, the returned bytes are hashed. When it reports no page count, the count is 0.

Tests

  • FilinqTemplateEngineAdapterTest: the chain double now answers versionInForceAt(). Two tests are new or rewritten: the query is asked for the end of the effective date, and a failing query falls back to the template's own version. Composition tests cover the reported digest and page count, and the fallback to the bytes. Four of the tests fail against the old adapter.
  • catch-return-null.allowlist.json: the reason names the new warning.
  • Unit suite (phpunit-unit.xml): before 18398 tests, after 18399. The same 16 failures occur in both runs (CaseTypeRightsEnforcedAccessTest, CaseTypeRuleProjectorTest, StatusEntryRequirementsGuardTest), so they are inherited from development.
  • phpstan: no errors on the adapter.

Generated by Claude Code

…ip ci]

The dossiq side of filinq's generated-document-names-its-template-version
(task 7.2): resolveVersion() asks filinq's versionInForceAt() for the
end of the effective date instead of walking the version chain itself,
and the composition takes the sha256 and pageCount filinq reports, so
countPages() and its regular expression over the PDF are gone.

Assisted-by: ClaudeCode:claude-opus-5-5

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant