Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 22 additions & 2 deletions appinfo/info.xml
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,17 @@
- **Sub-cases**: break a complex case into a parent and its children
- **Confidentiality levels**: eight levels from public to top secret, defaulted from the case type
- **My Work dashboard**: your assigned cases and open tasks in one place
- **Standards-aligned**: modelled on CMMN 1.1 and the ZGW APIs

**For Dutch government case work**

- **VTH process templates**: six seeded workflows for permits, supervision, enforcement and demolition notices
- **Objections and appeals**: the Awb bezwaar and beroep route, with hearings and an advisory committee
- **Wet open overheid (Woo) requests**: handle a disclosure request and assess what can be published
- **Workflow board**: move a case between statuses on a board, by drag or by keyboard
- **Deadline monitoring**: watch the decision term, and calculate the dwangsom penalty when it runs out
- **Case map**: see your cases plotted by location, with configurable layers
- **Appointment booking**: let a citizen pick a timeslot, then cancel it or record a no-show
- **Standards-aligned**: deep ZGW API alignment, with workflow templates modelled on CMMN case-management concepts

**Requires:** [OpenRegister](https://apps.nextcloud.com/apps/openregister) (install from the [Nextcloud App Store](https://apps.nextcloud.com/apps/openregister)).

Expand All @@ -40,7 +50,17 @@ Free and open source under the EUPL-1.2 licence.
- **Subzaken**: splits een complexe zaak op in een ouderzaak en haar deelzaken
- **Vertrouwelijkheidsniveaus**: acht niveaus van openbaar tot staatsgeheim, standaard vanuit het zaaktype
- **Mijn Werk dashboard**: je toegewezen zaken en openstaande taken op één plek
- **Aansluitend op standaarden**: gemodelleerd naar CMMN 1.1 en de ZGW API's

**Voor de Nederlandse overheid**

- **VTH-processjablonen**: zes ingerichte workflows voor vergunning, toezicht, handhaving en sloopmelding
- **Bezwaar en beroep**: de Awb-route, met hoorzittingen en een adviescommissie
- **Wet open overheid (Woo)-verzoeken**: behandel een verzoek en beoordeel wat openbaar kan
- **Workflowbord**: verplaats een zaak tussen statussen, met de muis of het toetsenbord
- **Termijnbewaking**: bewaak de beslistermijn en bereken de dwangsom als die verloopt
- **Zaakkaart**: zie je zaken op de kaart, met instelbare lagen
- **Afspraken**: laat een inwoner een tijdslot kiezen, annuleren of als no-show vastleggen
- **Aansluitend op standaarden**: diepe ZGW API-aansluiting, met workflowsjablonen gemodelleerd naar CMMN-concepten

**Vereist:** [OpenRegister](https://apps.nextcloud.com/apps/openregister) (installeer via de [Nextcloud App Store](https://apps.nextcloud.com/apps/openregister)).

Expand Down
Original file line number Diff line number Diff line change
@@ -1,8 +1,8 @@
## ADDED Requirements

### Requirement: Cross-surface feature vocabulary SHALL match shipped code
The app's four public surfaces — `appinfo/info.xml`, `src/manifest.json` nav/menu, the
conduction.nl product page (EN + NL), and the `docs/` site — SHALL describe the same canonical
The app's four public surfaces (`appinfo/info.xml`, `src/manifest.json` nav/menu, the
conduction.nl product page in EN and NL, and the `docs/` site) SHALL describe the same canonical
feature vocabulary, derived from `lib/Controller/`, `lib/BackgroundJob/`, and the manifest nav.
Any feature named on the product page or in info.xml SHALL be traceable to a controller, service,
background job, or Vue view in the shipped code.
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,12 @@
- [x] CMMN 1.1 / ZGW API standards claims
- [x] Update `appinfo/info.xml` EN + NL descriptions: add VTH/bezwaar-beroep/WOO/dwangsom/map/
appointments/kanban to the feature list; correct the CMMN/ZGW standards line.
- This box was ticked in July with the edit absent. `appinfo/info.xml` still carried the
original ten bullets and the "modelled on CMMN 1.1" standards line until 2026-09-09, when
the openspec triage sweep caught it and the edit was made for real. Every one of the seven
added bullets was re-verified against the tree first, not against this proposal: the
navigation has moved a lot since July, so the July wording could not be trusted as a
description of what ships now.
- [x] Update `conduction-website/src/pages/apps/dossiq.mdx`: version/status, FeatureList,
WidgetShelf widget names, RotatingCards wording, Showcase (n8n only, real AI feature),
PairCard wording.
Expand Down
Original file line number Diff line number Diff line change
@@ -0,0 +1,93 @@
## ADDED Requirements

### Requirement: A grant scheme is a case type (REQ-CT-21)

A grant scheme is the blueprint a category of cases is governed by, which is the
sentence that defines a case type. The system SHALL model a subsidieregeling as
a `caseType` plus its `propertyDefinition` records, and SHALL NOT carry a
parallel `subsidieRegeling` schema for the same concept.

Four of the retired schema's properties map onto fields the case type already
has: `schemeName` onto `title`, `termStart` and `termEnd` onto `validFrom` and
`validUntil`, `requestTermWeeks` onto `processingDeadline`, and `legalBasis`
onto `purpose`. The remaining grant-specific properties become
`propertyDefinition` records scoped to that case type.

`requestTermWeeks` was a bare integer and `processingDeadline` is an ISO-8601
duration. The migration SHALL convert it, because an integer stores happily and
is understood by neither the renderer nor the Awb 4:13 deadline calculation.

`subsidieAanvraag.subsidyScheme` SHALL `$ref` `caseType`. It was already a uuid
reference, so the shape of the property does not change.

#### Scenario: A migrated scheme carries its fields, not just its name
@e2e tests/e2e/spec-coverage/subsidieregeling-is-a-casetype.spec.ts

- **GIVEN** an instance holding subsidieRegeling objects
- **WHEN** the migration has run
- **THEN** each scheme SHALL exist as a `caseType`
- **AND** its `validFrom`, `validUntil` and `purpose` SHALL be non-empty, not merely present

#### Scenario: The decision term becomes a duration, not an integer
@e2e tests/e2e/spec-coverage/subsidieregeling-is-a-casetype.spec.ts

- **GIVEN** a scheme whose `requestTermWeeks` was 13
- **WHEN** the migration has run
- **THEN** the case type's `processingDeadline` SHALL read as an ISO-8601 duration such as `P13W`

#### Scenario: The grant-specific properties survive as property definitions
@e2e tests/e2e/spec-coverage/subsidieregeling-is-a-casetype.spec.ts

- **GIVEN** a scheme carrying `plafond`, `targetGroup` and `auditorsStatementThreshold`
- **WHEN** the migration has run
- **THEN** each SHALL exist as a `propertyDefinition` on the migrated case type

### Requirement: A property definition can carry an enum or a JSON document (REQ-CT-22)

`propertyDefinition.propertyType` SHALL offer `enum` and `json` alongside the
scalar types. An `enum` carries its allowed values in `enumValues`. A `json`
carries a JSON Schema and is validated as a document rather than as a scalar.

Both exist because of what the alternative does. Flattening a four-value enum to
a bare string keeps the value and loses the constraint, and flattening a JSON
Schema keeps the text and loses the shape. Neither loss raises anything, so a
migration that flattened would report the same success as one that did not.

#### Scenario: An enum property keeps its allowed values
@e2e tests/e2e/spec-coverage/subsidieregeling-is-a-casetype.spec.ts

- **GIVEN** a scheme carrying `interimReportFrequency` with four allowed values
- **WHEN** the migration has run
- **THEN** its `propertyDefinition` SHALL have `propertyType` `enum`
- **AND** its `enumValues` SHALL still list those values, because an enum with no `enumValues` is indistinguishable from a string

### Requirement: Schemes are administered on the Case types index (REQ-CT-23)

The `/subsidieregelingen` page and its Subsidy schemes menu entry SHALL be
retired. A grant scheme is administered where every other case type is
administered, on the Case types index, so there is one index over blueprints
rather than two.

Retiring the route SHALL NOT break it. The route SHALL fall through rather than
error, so a bookmark or an old link lands somewhere rather than on a server
error.

The `subsidieRegeling` schema SHALL be retained for one release, marked
deprecated, and removed only once the migration has run everywhere. A schema the
register no longer carries returns zero rows, and a migration that reads nothing
reports the same success as one that had nothing to do. For the same reason the
repair step SHALL report the counts it converted rather than reporting success.

#### Scenario: The menu offers Case types and not Subsidy schemes
@e2e tests/e2e/spec-coverage/subsidieregeling-is-a-casetype.spec.ts

- **WHEN** a handler opens the app navigation
- **THEN** it SHALL NOT carry a Subsidy schemes entry
- **AND** it SHALL carry a Case types entry, because the absence check alone would pass on a build where the capability vanished

#### Scenario: The retired route falls through rather than erroring
@e2e tests/e2e/spec-coverage/subsidieregeling-is-a-casetype.spec.ts

- **WHEN** a handler opens `/subsidieregelingen`
- **THEN** no scheme index SHALL render, tested on the page's own create control rather than a heading
- **AND** the page SHALL NOT show a server error
Original file line number Diff line number Diff line change
@@ -0,0 +1,68 @@
# Tasks: subsidieregeling-is-a-casetype

Written retroactively on 2026-09-09. The work shipped on 2026-08-27 in
`05919d25`, but the change directory was only ever a proposal: no tasks, no spec
delta. That is why it sat in `openspec/changes/` for two weeks after it was
finished. Every box below was verified against `development` before it was
ticked, and the evidence is on the box.

## 1. The schema

- [x] 1.1 Re-point `subsidieAanvraag.subsidyScheme` from `subsidieRegeling` to
`caseType`, keeping the uuid shape.
- `lib/Settings/register.d/50-subsidie.json:40` carries
`"$ref": "caseType"` and names this change in its description.
- [x] 1.2 Add `enum` and `json` to `propertyDefinition.propertyType`.
- both are in the enum in `lib/Settings/dossiq_register.json`, with the
description recording why flattening them to `string` was refused.
- [x] 1.3 Mark `subsidieRegeling` deprecated and keep it for one release rather
than deleting it, so the migration can still resolve and read the rows it
converts.
- `lib/Settings/register.d/50-subsidie.json` carries the DEPRECATED
description and the reason: a schema the register no longer carries returns
zero rows, and a migration that reads nothing reports success.

## 2. The migration

- [x] 2.1 Write `MigrateSubsidieRegelingToCaseType`: map the four direct fields,
convert `requestTermWeeks` to an ISO-8601 duration, and turn the remaining
grant-specific properties into `propertyDefinition` records.
- `lib/Repair/MigrateSubsidieRegelingToCaseType.php`.
- [x] 2.2 Make it report counts rather than success, and handle an empty set
gracefully.
- the class docblock records the measurement it was written against, 2
`subsidieRegeling` objects and 0 `subsidieAanvraag` rows referencing them,
and says an instance with two thousand rows is a different change.
- [x] 2.3 Unit-test the migration.
- `tests/Unit/Repair/MigrateSubsidieRegelingToCaseTypeTest.php`.

## 3. The surface

- [x] 3.1 Remove `/subsidieregelingen` and its Subsidy schemes menu entry;
schemes are administered on the Case types index.
- `git grep subsidieregelingen -- src` returns nothing.
- [x] 3.2 Leave the retired route falling through rather than erroring.
- asserted in `tests/e2e/spec-coverage/subsidieregeling-is-a-casetype.spec.ts`
on the page's own create control, because a retired route falls through to
the app root and the root has headings of its own.

## 4. Coverage

- [x] 4.1 Cover the migration and the retired surface end to end.
- `tests/e2e/spec-coverage/subsidieregeling-is-a-casetype.spec.ts`, six tests
across two describes.
- [x] 4.2 Write the spec delta this change never had, against `case-types`.
- `specs/case-types/spec.md`, REQ-CT-21 to REQ-CT-23. `case-types` rather than
`subsidieverlening-keten` because every requirement here is about how a
blueprint is modelled and administered, not about the grant chain's
lifecycle: the four field mappings, the `propertyType` extension, the
`propertyDefinition` records and the index the schemes moved onto are all
case-type machinery. Nothing here touches aanvraag, beoordeling, beschikking
or vaststelling.

## 5. Left for the follow-up

- [ ] 5.1 Delete the `subsidieRegeling` schema once the migration has run on
every instance. Deliberately not done here: 1.3 keeps it for one release on
purpose, and deleting it in the same change would leave the migration reading
zero rows and reporting success.
55 changes: 55 additions & 0 deletions openspec/specs/beta-alignment/spec.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,55 @@
# beta-alignment Specification

## Purpose

The rule that what we say the app does matches what it does. dossiq describes
itself on four surfaces: `appinfo/info.xml`, the manifest navigation, the
conduction.nl product page in English and Dutch, and the docs site. They drifted
apart from each other, and in several places from the code.

A feature named on any of those surfaces has to be traceable to a controller, a
service, a background job or a Vue view that ships. A mocked adapter is
described as pluggable, never as behaviour. An integration with another app
needs a code reference in one of them, or it is positioning rather than an
integration.

## Requirements

### Requirement: Cross-surface feature vocabulary SHALL match shipped code
The app's four public surfaces (`appinfo/info.xml`, `src/manifest.json` nav/menu, the
conduction.nl product page in EN and NL, and the `docs/` site) SHALL describe the same canonical
feature vocabulary, derived from `lib/Controller/`, `lib/BackgroundJob/`, and the manifest nav.
Any feature named on the product page or in info.xml SHALL be traceable to a controller, service,
background job, or Vue view in the shipped code.

#### Scenario: VTH process templates named on the product page match shipped templates
- **WHEN** the product page lists named VTH case-type templates
- **THEN** every named template SHALL exist under `lib/Settings/vth-templates/` or
`lib/Settings/templates/`
- **AND** no template name SHALL be invented or drawn only from free-text sample data

#### Scenario: Third-party/standard integration claims require live code
- **WHEN** the product page or info.xml claims an integration with a named external product,
service, or standard (e.g. a document/signing engine, a workflow-automation tool, a PII-redaction
library, a compliance standard)
- **THEN** the claim SHALL be backed by a real service call, adapter implementation, or dependency
declaration in `lib/` or `composer.json`/`package.json`
- **AND** a merely-mocked adapter (e.g. an interface whose only implementation is a `Mock*Adapter`)
SHALL be described as pluggable/optional, not as a live default behaviour

#### Scenario: Cross-app integration claims require shared code or shared data wiring
- **WHEN** the product page claims that another Conduction app (e.g. a citizen-facing portal)
integrates with Dossiq (e.g. "applicants track their case live")
- **THEN** there SHALL be at least one code reference in either app pointing at the other (shared
register schema consumption, an API call, or an explicit adapter), or the claim SHALL be reworded
to describe ecosystem positioning rather than a functioning integration

#### Scenario: Dashboard widget names on the product page match real widget titles
- **WHEN** the product page names specific dashboard widgets shipped with the app
- **THEN** each named widget SHALL correspond to a real `OCP\Dashboard\IWidget` implementation's
`getTitle()` return value registered in `lib/AppInfo/Application.php`

#### Scenario: Version and release-status labels are sourced from info.xml
- **WHEN** the product page displays a version number and release-status badge (e.g. Beta/Stable)
- **THEN** the version SHALL match `appinfo/info.xml`'s `<version>` value
- **AND** the status label SHALL reflect the app's actual major-version maturity (pre-1.0 = Beta)
Loading
Loading