Skip to content
This repository was archived by the owner on Aug 4, 2026. It is now read-only.

fix(security): wave-3 critical fixes - #70

Merged
rubenvdlinde merged 1 commit into
developmentfrom
fix/wave3-critical-findings
May 28, 2026
Merged

rubenvdlinde merged 1 commit into
developmentfrom
fix/wave3-critical-findings

Conversation

@rubenvdlinde

Copy link
Copy Markdown
Contributor

Wave-3 Critical Findings — deskdesk

Fixes all REAL findings from the wave-3 security review.

Changes

C1 — Booking schema RBAC (lib/Settings/deskdesk_register.json)
Added delete rule (was ["admin"] — blocked owners and booking users) and create rule (was absent) with dual-match OR-native enforcement so owners and booking subjects can manage their own bookings via OR schema-RBAC.

C2 — knowledge_article missing from register schemas array
Added "knowledge_article" to the register-block schemas array. Without this, KnowledgeTab.vue was querying a schema unattached to the register — breaking the documented knowledge sidebar feature for every user. One-line fix.

C3 — Dead code removal
Deleted ItemController, ItemService, their routes (/api/items, /api/items/{id}), and both unit-test classes. Zero frontend callers verified. C1 schema rules handle booking access via OR-native RBAC directly.

C4 — NC version claim narrowed (appinfo/info.xml)
Changed min-version="28" max-version="34" to min-version="31" max-version="33" to match the CI matrix. Fleet-standard pattern.

Version bump: 0.2.0 → 0.2.1 (NC immutable-cache requirement)

Not fixed

  • C5 — <licence>agpl</licence> vs EUPL-1.2: intentional-by-design (NC store-picker workaround).

…ema, dead code

C1: Fix booking schema delete/create RBAC rules so owners and booking users
    can manage their own bookings via OR-native enforcement instead of
    admin-only (which made ItemService's isAuthorized() unreachable).

C2: Attach knowledge_article schema to the register-block schemas array so
    KnowledgeTab.vue can fetch articles — was defined but never registered.

C3: Remove dead-code ItemController, ItemService, routes, and tests — the
    /api/items endpoint has zero frontend callers; C1 now handles booking
    access via OR schema rules directly.

C4: Narrow info.xml NC version to min=31 max=33 to match CI matrix.
@rubenvdlinde
rubenvdlinde merged commit 527b911 into development May 28, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant