This repository was archived by the owner on Aug 4, 2026. It is now read-only.
Repository navigation
fix(security): wave-3 critical fixes - #70
Merged
Merged
Conversation
…ema, dead code
C1: Fix booking schema delete/create RBAC rules so owners and booking users
can manage their own bookings via OR-native enforcement instead of
admin-only (which made ItemService's isAuthorized() unreachable).
C2: Attach knowledge_article schema to the register-block schemas array so
KnowledgeTab.vue can fetch articles — was defined but never registered.
C3: Remove dead-code ItemController, ItemService, routes, and tests — the
/api/items endpoint has zero frontend callers; C1 now handles booking
access via OR schema rules directly.
C4: Narrow info.xml NC version to min=31 max=33 to match CI matrix.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Wave-3 Critical Findings — deskdesk
Fixes all REAL findings from the wave-3 security review.
Changes
C1 — Booking schema RBAC (
lib/Settings/deskdesk_register.json)Added
deleterule (was["admin"]— blocked owners and booking users) andcreaterule (was absent) with dual-match OR-native enforcement so owners and booking subjects can manage their own bookings via OR schema-RBAC.C2 —
knowledge_articlemissing from register schemas arrayAdded
"knowledge_article"to the register-blockschemasarray. Without this,KnowledgeTab.vuewas querying a schema unattached to the register — breaking the documented knowledge sidebar feature for every user. One-line fix.C3 — Dead code removal
Deleted
ItemController,ItemService, their routes (/api/items,/api/items/{id}), and both unit-test classes. Zero frontend callers verified. C1 schema rules handle booking access via OR-native RBAC directly.C4 — NC version claim narrowed (
appinfo/info.xml)Changed
min-version="28" max-version="34"tomin-version="31" max-version="33"to match the CI matrix. Fleet-standard pattern.Version bump: 0.2.0 → 0.2.1 (NC immutable-cache requirement)
Not fixed
<licence>agpl</licence>vs EUPL-1.2: intentional-by-design (NC store-picker workaround).