This repository was archived by the owner on Aug 4, 2026. It is now read-only.
Repository navigation
fix: correct OR delete API, add booking read auth, and enforce user field on create - #68
Merged
Merged
Conversation
…ield on create C1: replace non-existent ObjectService::delete() with deleteObject(uuid, register, schema) and align test stub to the canonical signature. H1: add POST /api/items create endpoint that forces booking.user to the caller's UID for non-admins, preventing user impersonation. H2: add per-user read authorization to the booking schema so users only see their own bookings; bump booking schema to 0.3.0 and register to 0.5.0 to trigger reimport. H3: bump appinfo/info.xml to 0.2.0 to bust the immutable JS bundle cache.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ObjectService::delete()call with the canonicaldeleteObject(uuid, register, schema)signature; alignItemServiceTeststub to match.POST /api/itemscreate endpoint that forcesbooking.userto the caller's own UID for non-admins, preventing user impersonation.readauthorization rule to the booking schema so users only see their own bookings; bump booking schema to0.3.0and register to0.5.0to trigger reimport.appinfo/info.xmlto0.2.0to bust the immutable JS bundle cache.Test plan
create()service method)POST /api/itemswith non-admin user: confirmbooking.useris always set to the acting userGET /api/objects/{registerId}/bookingas non-owner: confirm 403 (H2 read auth)GET /api/objects/{registerId}/bookingas booking owner/subject: confirm 200