Repository navigation
feat(global-settings): block hand-rolled waiting, 2.5.0 - #763
Merged
Merged
Conversation
…s, long sleeps, idle heartbeats), 2.5.0
WilcoLouwerse
added a commit
that referenced
this pull request
Sep 15, 2026
…ective
ShellCheck failed the branch on test-block-polling.sh:76:
expect allow 'until_date=2026-09-12; echo $until_date'
SC2016: Expressions don't expand in single quotes, use double quotes
The single quotes are the point. This harness feeds literal command strings
to the hook as DATA, so an expanded $until_date would test something the
hook never sees. Its two sibling harnesses — test-block-write-commands.sh
and test-block-config-tool-writes.sh — already carry the same directive on
line 2 with the same reason; the file added in #763 just missed it.
No VERSION bump: this is a lint annotation on a test, with no behaviour
change for anything consuming global-settings.
Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Item 5 of the 2026-09-12 velocity diagnosis (https://claude.ai/code/artifact/25ce5f91-817d-43f6-85a5-508304aa5131). In twelve days of sessions the transcripts held 2,043 idle heartbeats, 929 bare
truecalls, 395 streaks of five or more consecutive CI polls and 35.7 hours of sleep loops. A session that waits by hand burns turns and context; a session that pushes and moves on does not, and 96 percent of CI wall-clock is queueing anyway.What changes
global-settings/block-polling.sh: a PreToolUse guard on Bash that deniesgh run watch,gh pr checks --watch,whileoruntilloops aroundsleep, asleepof 60 seconds or more, theecho idleandecho waitingheartbeats, andtail -fon/dev/null. It allows short sleeps, a one-shotgh pr checksorgh run view, pushes, and any grep that merely mentions the words. The denial message says what to do instead.settings.jsonright afterblock-write-commands.sh; README table row and install line; VERSION 2.4.6 to 2.5.0 (a new hook is a minor bump).tests/test-block-polling.sh: 14 deny and 15 allow cases, with a positive control so a hook that denies nothing cannot read as green. Wired intohook-tests.yml.Verified locally
bash global-settings/tests/test-block-polling.sh: 29 passed, 0 failed, exit 0.HOOK=/bin/truemakes the harness exit 1.shellcheck -S warningon the hook: exit 0.bash -n: exit 0.settings.jsonandhook-tests.ymlparse.