Skip to content

fix(gate-53): prove the vendored manifest schema is current, and sync the widget list - #671

Merged
rubenvdlinde merged 1 commit into
mainfrom
fix/gate-53-manifest-schema-drift-acceptance
Sep 3, 2026
Merged

rubenvdlinde merged 1 commit into
mainfrom
fix/gate-53-manifest-schema-drift-acceptance

Conversation

@rubenvdlinde

Copy link
Copy Markdown
Contributor

dossiq#1729 failed dossiq's Dashboard on at /pages/0/config/headerActions/0: must NOT have additional properties, and the manifest was right.

Which side was stale

CnActionButtons binds every one of the disputed keys straight onto CnFormDialog:

:include-fields="formEntry.includeFields || null"
:exclude-fields="formEntry.excludeFields || []"
:field-overrides="formEntry.fieldOverrides || {}"
:size="formEntry.size || 'normal'"
:columns="formEntry.columns || 1"

So the runtime renders them, and dossiq#1713 narrowed the "New case" form on purpose. What was stale was this package's vendored schema — 2.26.0, shipped as v1.11.0. Reproduced end to end: dossiq's real development manifest FAILS against the v1.11.0 copy with exactly the reported string, and PASSES against main.

main is already current — #664 synced to 2.28.0, #667 to 2.29.0, and the vendored file is now byte-identical to nextcloud-vue's development copy. The fix is merged but unreleased, which is why the fleet still sees it.

Why it shipped three times

Both syncs landed with no fixture, so nothing here could tell a current vendored schema from a stale one.

FAMILY K closes that. The clean arm carries the whole open-form option set; the planted arm carries two independently fatal defects in the same action — an unknown key (includeFieldz) and an out-of-enum size — so a schema "fixed" by setting additionalProperties: true, or by dropping the enum, passes the clean arm and fails the planted one.

Negative control: re-introducing the 2.26.0 schema reddens family K and names the same path #1729 reported.

The sweep found one more

BUILT_IN_WIDGET_KEYS in check_manifest.js feeds the ADR-036 Decision 1 rule and had six keys while nextcloud-vue's validator had eleven and its v2 runtime registry fifteen. A dashboard whose single 12x12 widget was a library built-in (banner, header, text, divider, audit-trail, metadata, …) was told to "declare as type:custom and register the component with kind:page" — advice the app cannot follow, because it does not own the component. The set is now the union of the library's validator list and the registry CnWidgetGrid actually resolves against.

FAMILY L is its pair: a library built-in passes, an app-owned widget still fails, so the rule is updated rather than retired. Negative control: restoring the six-key list reddens the built-in arm and leaves the app-owned one failing.

The dashboard-catalog fallback (table, object-list, map, countdown, tabs) is a known remaining gap, recorded in the code — nextcloud-vue's own validator flags those too, so it is a change to make there first.

Also swept and found in sync: semantic-icons.json (155 entries, no value mismatches), SLOT_COLUMNS_DEFAULTS, and all five observability enums.

Verification

  • test_gate_45_to_55_acceptance.sh — ALL GREEN, including 5 new assertions
  • Full helper-suite run, before and after: 104 passed, 0 failed, 2 quarantined with reasons
  • Both negative controls reproduce the defect they guard

🤖 Generated with Claude Code

… the widget list

dossiq#1729 failed dossiq's Dashboard on

  at /pages/0/config/headerActions/0: must NOT have additional properties

and the manifest was right. CnActionButtons binds includeFields,
excludeFields, fieldOverrides, size and columns straight onto CnFormDialog,
so the runtime renders every one of them; the narrowed "New case" form was
a deliberate feature (dossiq#1713). What was stale was this package's
vendored copy of the schema, 2.26.0, shipped as v1.11.0.

That copy is already current on main: #664 synced it to 2.28.0 and #667 to
2.29.0, and it is now byte-identical to nextcloud-vue's development copy.
Both syncs landed with no fixture, which is why the drift could ship three
times: nothing here could tell a current vendored schema from a stale one.

FAMILY K closes that. Its clean arm carries the whole open-form option set
and its planted arm carries two independently fatal defects in the same
action — an unknown key and an out-of-enum size — so a schema "fixed" by
setting additionalProperties to true, or by dropping the enum, passes the
clean arm and fails the planted one. Verified by re-introducing the 2.26.0
schema: family K goes red and names the same path #1729 reported.

The sweep for the same class found one more, in check_manifest.js rather
than in the schema. BUILT_IN_WIDGET_KEYS feeds the ADR-036 Decision 1 rule
and had six keys while nextcloud-vue's validator had eleven and its v2
runtime registry fifteen. A dashboard whose single 12x12 widget is a
library built-in — banner, header, text, divider, audit-trail, metadata —
was told to "declare as type:custom and register the component with
kind:page", advice the app cannot follow because it does not own the
component. The set is now the union of the library's validator list and the
registry CnWidgetGrid actually resolves against.

FAMILY L is its pair: a library built-in passes, an app-owned widget still
fails, so the anti-pattern rule is updated rather than retired. Verified by
restoring the six-key list, which reddens the built-in arm and leaves the
app-owned one failing.

The dashboard-widget catalog fallback (table, object-list, map, countdown,
tabs) is a known remaining gap, recorded in the code: nextcloud-vue's own
validator flags those too, so it is a change to make there first.

Full helper-suite run green before and after: 104 passed, 0 failed, 2
quarantined with reasons.

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
@rubenvdlinde
rubenvdlinde merged commit 3adf0f3 into main Sep 3, 2026
36 of 38 checks passed
@rubenvdlinde
rubenvdlinde deleted the fix/gate-53-manifest-schema-drift-acceptance branch September 3, 2026 12:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant