Skip to content

gate-60 can NEVER report in CI: it is applicable only when a PR touches a manifest, and in exactly that case its tool is missing — with require-full-coverage it then BLOCKS the PR #314

Open

Description

@rubenvdlinde

Summary

gate-60 (icon-vocabulary) is diff-scoped to manifest changes and depends on vue-material-design-icons, which the shared quality workflow never installs. The two facts combine into a gate that can only ever produce two outcomes in CI:

  • PR does not touch a manifest → NOT APPLICABLE (excluded from coverage) → never inspects anything.
  • PR does touch a manifest → applicable → tool missing → SKIPPED (wiring) → with hydra-gates-require-full-coverage set, the run fails.

So the icon vocabulary is verified exactly never, and the gate additionally blocks every manifest-touching PR. That is the "falsely RED / permanently pending" dead-gate shape, fleet-wide.

Evidence

.github/workflows/quality.yml, Hydra Gates job — the only npm install is:

- name: Install ajv for the manifest gates
  run: npm --prefix gates/hydra-gates install --no-save --no-audit --no-fund ajv

The app's own dependencies are never installed for this job, so vue-material-design-icons is absent.

Measured on pipelinq:

  • development (f6bb0616), diff touched no manifest:
    [gate-60] icon-vocabulary: NOT APPLICABLE — src/manifest.json exists here and the diff
    against '2501ce1d…' touched no manifest, so NO icon was inspected.
    
  • pipelinq#742, which touches src/manifest.json and five manifest fragments:
    [gate-60] icon-vocabulary: SKIPPED (wiring) — vue-material-design-icons is not installed,
    so icon names could NOT be verified to exist upstream … Run npm ci to restore full coverage.
    
    and the job then fails with:
    ##[error]hydra-gates passed every gate that ran, but a gate whose SUBJECT MATTER EXISTS
    did not report, and hydra-gates-require-full-coverage is set.
    
    Note the wording: it passed every gate that ran. There were no findings. The run failed purely because gate-60 could not execute.

Gate package on those runs: 365fa31d09a26f980e6dc76cb0800575ef005a4e.

This is not hypothetical — it hid a real bug

Running the gates locally with node_modules present is what caught an actual defect in pipelinq#742. I had replaced an unregistered widget icon with Timeline, which is in nc-vue's widgetIcons.js and is in gate-55's mirror of it, but is not in the app's own src/icons.js (ADR-077). gate-55 was green on it; only gate-60 reported it:

FAIL src/icons.js: 1 icon name(s) used by the manifests are NOT registered — they render
with no icon at all, not a fallback: Timeline (ADR-077 rule 3).

In CI that icon would have shipped under a green board, rendering nothing. (The stale gate-55 mirror is filed separately as #304.)

Suggested fix

Install the app's frontend dependencies before the gates step in quality.yml, e.g. an npm ci (or at minimum npm install --no-save vue-material-design-icons) gated on package-lock.json existing, so gate-60 can resolve icon names.

Failing that, gate-60 should report SKIPPED (wiring) without counting against require-full-coverage — but that trades a blocking gate for a silently unverified one, which is the worse half of the trade and the thing #242/#258/#268 were written to stop. Installing the dependency is the honest fix.

Impact

Any repo in the fleet with enable-hydra-gates: true, require-full-coverage, and a src/manifest.json cannot merge a manifest change without an admin override.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions