Skip to content

gate-55 and gate-60 encode two different icon registries for the same widget field — 'settings' is unsatisfiable #203

Closed

Description

@rubenvdlinde

A widget icon for the "settings" concept cannot satisfy both gates. Verified against the installed library, not inferred.

The deadlock

gate rule verdict on Cog verdict on CogOutline
55 detail-page-discipline widget icon must be in the shared widget registry PASS FAIL — "not in the shared icon registry (renders the ? fallback, ADR-062 rule 8)"
60 icon-vocabulary concept settings MUST use CogOutline (ADR-077 Tier A) FAIL PASS

Hit on ConductionNL/hermiq#162, widget agent-core titled "Configuration" on AgentDetail.

Which registry is right

Checked the source of truth check_detail_page_discipline.py names — nextcloud-vue/src/components/CnWidgetGrid/widgetIcons.js, as installed in node_modules:

grep -c CogOutline widgetIcons.js   ->  0
grep -c bCogb   widgetIcons.js   ->  2

So gate-55's hardcoded mirror is accurate: CogOutline genuinely is not there, and using it renders the ? fallback. ADR-077 Tier A therefore mandates, for widget icons, a glyph the widget renderer cannot draw.

Why this is gate-60's overreach, not a repo defect

Gate 60 is introduced in run-hydra-gates.sh:3908 as "every manifest menu icon", but _menu_entries() deliberately walks the whole tree:

Originally menu-only. … page/tab/widget icons and actions[] / headerActions[] entries render through the same CnIcon registry and hit exactly the same failure modes … So the gate now walks the whole tree.

That premise does not hold for widget icons: they render through CnWidgetGrid's own widgetIcons.js registry, which is a strict subset of the CnIcon vocabulary. Two registries, one field.

Suggested

Either

  1. exempt widget icons from gate-60's Tier A concept mapping (menus keep it), or
  2. reconcile the registries — add CogOutline and the other Tier A glyphs to widgetIcons.js, so the vocabulary ADR-077 mandates is one the widget renderer can actually draw.

(2) is the better end state; (1) unblocks immediately.

Until then, any PR touching a widget labelled Configuration / Settings / Instellingen / Configuratie is blocked, and gate-60 has no documented opt-out — unlike gate-49, which takes [hydra-gate-controller-exception-translation exclude] <reason>.

Related

gate-49 has a narrower version of the same shape: it tracks nine named domain exceptions and does not recognise catch (\Throwable), which is strictly BROADER and covers all nine. Filing separately.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions