Remove writting of packages with numpy as this is now obsolete - #133
Merged
Merged
Conversation
There was a problem hiding this comment.
🟢 Approval recommended
The removed tracking file has no remaining references in the repository and the script change cleanly eliminates dead/obsolete behavior without affecting the pinning logic.
Pull request overview
Removes the obsolete mechanism that tracked wheel builds referencing a specific NumPy C-API version, reflecting that this list is no longer maintained/needed now that NumPy 1.x and 2.x are supported without oldest-supported-numpy.
Changes:
- Deletes
packages_w_numpy_api.txt(previously a manually-committed tracking list). - Removes the
build_wheel.shlogic that appended package names topackages_w_numpy_api.txtduring NumPy link-info inspection.
File summaries
| File | Description |
|---|---|
| packages_w_numpy_api.txt | Removes the now-obsolete tracked package list. |
| build_wheel.sh | Stops recording packages into the removed tracking file while keeping NumPy pin adjustment behavior intact. |
Review details
- Files reviewed: 2/2 changed files
- Comments generated: 0
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before
oldest-supported-numpywe needed to track packages, but now with numpy 2.x and 1.x it has become stale.