You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I would expect a conversion failure to result in a non-zero exit code, but I am seeing 0 in my test cases:
$ docker run -it --rm quay.io/biocontainers/thermorawfileparser:1.3.4--ha8f3691_0 ThermoRawFileParser.sh -i=/dev/null
2022-06-30 17:15:24 INFO Started parsing /dev/null
2022-06-30 17:15:24 ERROR Unable to access the RAW file using the native Thermo library.
$ echo$?
0
In the new release 1.4.1, I have (fingers crossed) fixed error codes. Now error code indicates the number of errors during the processing. Using -w key one can include number of warnings in the error code.
I will close the issue now, feel free to reopen it, if necessary.
Activity
caetera commentedon Jul 11, 2022
@wholtz thank you for reporting. I will make sure exit codes will be as expected.
caetera commentedon Oct 21, 2022
In the new release 1.4.1, I have (fingers crossed) fixed error codes. Now error code indicates the number of errors during the processing. Using
-wkey one can include number of warnings in the error code.I will close the issue now, feel free to reopen it, if necessary.