Repository navigation
Return Camera Image (Stream) from ICameraView.CaptureImage() - #2695
Merged
TheCodeTraveler merged 7 commits intoJun 14, 2025
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR refactors ICameraView.CaptureImage() to return a Task<Stream> instead of ValueTask, implements a semaphore-protected event‐based capture flow, and adds disposal logic to CameraView.
- Introduces
IDisposableonCameraViewfor cleanup ofSemaphoreSlim - Changes
CaptureImagetoasync Task<Stream>, usesTaskCompletionSource<Stream>withMediaCaptured/MediaCaptureFailedevents - Updates
ICameraViewinterface signature and adjusts related bindable property defaults
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/CommunityToolkit.Maui.Camera/Views/CameraView.shared.cs | Added IDisposable, semaphore management, new CaptureImage logic |
| src/CommunityToolkit.Maui.Camera/Interfaces/ICameraView.shared.cs | Updated CaptureImage from ValueTask to Task<Stream> |
Comments suppressed due to low confidence (2)
src/CommunityToolkit.Maui.Camera/Views/CameraView.shared.cs:221
- The new
CaptureImagebehavior (success, failure, cancellation, and concurrent calls) isn’t covered by existing tests—consider adding unit or integration tests to validate event unsubscription, exception paths, and semaphore behavior.
public async Task<Stream> CaptureImage(CancellationToken token)
src/CommunityToolkit.Maui.Camera/Interfaces/ICameraView.shared.cs:58
- Update any public API docs, samples, and IntelliSense comments to reflect that
CaptureImagenow returns aTask<Stream>instead ofValueTaskand no longer relies on theMediaCapturedevent.
Task<Stream> CaptureImage(CancellationToken token);
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
VladislavAntonyuk
approved these changes
Jun 11, 2025
TheCodeTraveler
enabled auto-merge (squash)
June 14, 2025 19:37
TheCodeTraveler
deleted the
Return-Camera-Image-from-`CameraView.CaptureImage()`
branch
June 14, 2025 20:12
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of Change
API Change
This PR updates
ICameraView.CaptureImage()to return theStreamcaptured by the camera:to
Developer Experience Improvement
This improves the developer experience, allowing devs to retrieve the image directly from the method, whereas the current/previous experience required them to subscribe to
CameraView.MediaCaptured:PR Checklist
approved(bug) orChampioned(feature/proposal)mainat time of PR