Repository navigation
Conversation
… clean again. It required me to break the CPM rule and target various versions - which isn't nice, but also is required since the OpenTelemetry.* packages are at varying numbers. It's possible there is a more elegant way to achieve this, but I wasn't aware of it. If you have dotnet 11 and are not in the dev container, the allowPrerelease will prevent you from building. The only warning is I believe an oustanding issue with .SqlProjects.
Contributor
|
🚀 Dogfood this PR with:
curl -fsSL https://raw.githubusercontent.com/CommunityToolkit/Aspire/main/eng/scripts/dogfood-pr.sh | bash -s -- 1299Or
iex "& { $(irm https://raw.githubusercontent.com/CommunityToolkit/Aspire/main/eng/scripts/dogfood-pr.ps1) } 1299" |
Contributor
There was a problem hiding this comment.
Pull request overview
Draft follow-up to #1296 that tries to stabilize the toolkit’s build/test experience by adjusting shared test behavior, refreshing OpenTelemetry-related dependencies, and reworking the devcontainer certificate setup used across this multi-integration Aspire repo.
Changes:
- Temporarily skips the shared TypeScript AppHost test helper used by many integration tests.
- Updates central OpenTelemetry package/version management and adds direct package references in the PowerShell and KurrentDB hosting packages.
- Switches devcontainer certificate handling toward
devcontainer-dev-certs, adds a devcontainer lock file, and updates related docs/ignores.
Reviewed changes
Copilot reviewed 9 out of 10 changed files in this pull request and generated 6 comments.
Show a summary per file
| File | Description |
|---|---|
tests/CommunityToolkit.Aspire.Testing/TypeScriptAppHostTest.cs |
Adds an unconditional skip to the shared TypeScript AppHost test helper. |
src/CommunityToolkit.Aspire.Hosting.PowerShell/CommunityToolkit.Aspire.Hosting.PowerShell.csproj |
Adds OpenTelemetry and crypto package references to the PowerShell hosting package. |
src/CommunityToolkit.Aspire.Hosting.KurrentDB/CommunityToolkit.Aspire.Hosting.KurrentDB.csproj |
Adds OpenTelemetry.Api to the KurrentDB hosting package. |
docs/setup.md |
Documents an extra devcontainer certificate-related setup note. |
Directory.Packages.props |
Revises central OpenTelemetry package versions and adds new centrally managed package entries. |
Directory.Build.props |
Bumps the shared OpenTelemetryVersion property. |
.gitignore |
Ignores *.lscache files. |
.devcontainer/post-create.sh |
Removes the inline dotnet dev-certs trust step and leaves a note about the external extension. |
.devcontainer/devcontainer.json |
Adds the devcontainer-dev-certs feature to the devcontainer config. |
.devcontainer/devcontainer-lock.json |
Adds a lock file for devcontainer feature resolution. |
| IEnumerable<string>? requiredCommands = null, | ||
| CancellationToken cancellationToken = default) | ||
| { | ||
| Assert.Skip("Try skipping typescript tests"); |
| @@ -5,14 +5,7 @@ sudo apt-get update && \ | |||
| sudo apt clean -y && \ | |||
| sudo rm -rf /var/lib/apt/lists/* | |||
|
|
|||
| "name": "Aspire Community Toolkit", | ||
| "image": "mcr.microsoft.com/devcontainers/dotnet:10.0-noble", | ||
| "features": { | ||
| "ghcr.io/dnegstad/devcontainer-dev-certs/devcontainer-dev-certs:latest": {}, |
| <PackageVersion Include="OpenTelemetry.Instrumentation.EntityFrameworkCore" Version="1.15.1-beta.1" /> | ||
| <PackageVersion Include="OpenTelemetry.Instrumentation.Http" Version="1.15.1" /> | ||
| <PackageVersion Include="OpenTelemetry.Instrumentation.Runtime" Version="1.15.1" /> | ||
| <PackageVersion Include="OpenTelemetry.Api" Version="1.15.3" /> |
Comment on lines
+11
to
+13
| <PackageReference Include="OpenTelemetry.Api" /> | ||
| <PackageReference Include="OpenTelemetry.Exporter.OpenTelemetryProtocol" /> | ||
| <PackageReference Include="System.Security.Cryptography.Xml" /> |
| <ItemGroup> | ||
| <PackageReference Include="Aspire.Hosting" /> | ||
| <PackageReference Include="KurrentDB.Client" /> | ||
| <PackageReference Include="OpenTelemetry.Api" /> |
Co-authored-by: Copilot <copilot@github.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Member
|
All sorted as part of #1314 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
DO NOT MERGE YET
Follow on from #1296
Closes #<ISSUE_NUMBER>
PR Checklist
Other information