Skip to content

[Draft] Try fixing tests - #1299

Closed
afscrome wants to merge 5 commits into
CommunityToolkit:mainfrom
afscrome:package-upgrades
Closed

afscrome wants to merge 5 commits into
CommunityToolkit:mainfrom
afscrome:package-upgrades

Conversation

@afscrome

@afscrome afscrome commented May 4, 2026

Copy link
Copy Markdown
Contributor

DO NOT MERGE YET

Follow on from #1296

Closes #<ISSUE_NUMBER>

PR Checklist

  • Created a feature/dev branch in your fork (vs. submitting directly from a commit on main)
  • Based off latest main branch of toolkit
  • PR doesn't include merge commits (always rebase on top of our main, if needed)
  • New integration
    • Docs are written
    • Added description of major feature to project description for NuGet package (4000 total character limit, so don't push entire description over that)
  • Tests for the changes have been added (for bug fixes / features) (if applicable)
  • Contains NO breaking changes
  • Every new API (including internal ones) has full XML docs
  • Code follows all style conventions

Other information

Omnideth and others added 2 commits May 2, 2026 00:59
… clean again.

It required me to break the CPM rule and target various versions - which isn't nice, but also is required since the OpenTelemetry.* packages are at varying numbers.

It's possible there is a more elegant way to achieve this, but I wasn't aware of it.

If you have dotnet 11 and are not in the dev container, the allowPrerelease will prevent you from building.

The only warning is I believe an oustanding issue with .SqlProjects.
Copilot AI review requested due to automatic review settings May 4, 2026 19:52
@github-actions

github-actions Bot commented May 4, 2026 •

Copy link
Copy Markdown
Contributor

🚀 Dogfood this PR with:

⚠️ WARNING: Do not do this without first carefully reviewing the code of this PR to satisfy yourself it is safe.

curl -fsSL https://raw.githubusercontent.com/CommunityToolkit/Aspire/main/eng/scripts/dogfood-pr.sh | bash -s -- 1299

Or

  • Run remotely in PowerShell:
iex "& { $(irm https://raw.githubusercontent.com/CommunityToolkit/Aspire/main/eng/scripts/dogfood-pr.ps1) } 1299"

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Draft follow-up to #1296 that tries to stabilize the toolkit’s build/test experience by adjusting shared test behavior, refreshing OpenTelemetry-related dependencies, and reworking the devcontainer certificate setup used across this multi-integration Aspire repo.

Changes:

  • Temporarily skips the shared TypeScript AppHost test helper used by many integration tests.
  • Updates central OpenTelemetry package/version management and adds direct package references in the PowerShell and KurrentDB hosting packages.
  • Switches devcontainer certificate handling toward devcontainer-dev-certs, adds a devcontainer lock file, and updates related docs/ignores.

Reviewed changes

Copilot reviewed 9 out of 10 changed files in this pull request and generated 6 comments.

Show a summary per file
File Description
tests/CommunityToolkit.Aspire.Testing/TypeScriptAppHostTest.cs Adds an unconditional skip to the shared TypeScript AppHost test helper.
src/CommunityToolkit.Aspire.Hosting.PowerShell/CommunityToolkit.Aspire.Hosting.PowerShell.csproj Adds OpenTelemetry and crypto package references to the PowerShell hosting package.
src/CommunityToolkit.Aspire.Hosting.KurrentDB/CommunityToolkit.Aspire.Hosting.KurrentDB.csproj Adds OpenTelemetry.Api to the KurrentDB hosting package.
docs/setup.md Documents an extra devcontainer certificate-related setup note.
Directory.Packages.props Revises central OpenTelemetry package versions and adds new centrally managed package entries.
Directory.Build.props Bumps the shared OpenTelemetryVersion property.
.gitignore Ignores *.lscache files.
.devcontainer/post-create.sh Removes the inline dotnet dev-certs trust step and leaves a note about the external extension.
.devcontainer/devcontainer.json Adds the devcontainer-dev-certs feature to the devcontainer config.
.devcontainer/devcontainer-lock.json Adds a lock file for devcontainer feature resolution.

IEnumerable<string>? requiredCommands = null,
CancellationToken cancellationToken = default)
{
Assert.Skip("Try skipping typescript tests");
@@ -5,14 +5,7 @@ sudo apt-get update && \
sudo apt clean -y && \
sudo rm -rf /var/lib/apt/lists/*

"name": "Aspire Community Toolkit",
"image": "mcr.microsoft.com/devcontainers/dotnet:10.0-noble",
"features": {
"ghcr.io/dnegstad/devcontainer-dev-certs/devcontainer-dev-certs:latest": {},
Comment thread Directory.Packages.props
<PackageVersion Include="OpenTelemetry.Instrumentation.EntityFrameworkCore" Version="1.15.1-beta.1" />
<PackageVersion Include="OpenTelemetry.Instrumentation.Http" Version="1.15.1" />
<PackageVersion Include="OpenTelemetry.Instrumentation.Runtime" Version="1.15.1" />
<PackageVersion Include="OpenTelemetry.Api" Version="1.15.3" />
Comment on lines +11 to +13
<PackageReference Include="OpenTelemetry.Api" />
<PackageReference Include="OpenTelemetry.Exporter.OpenTelemetryProtocol" />
<PackageReference Include="System.Security.Cryptography.Xml" />
<ItemGroup>
<PackageReference Include="Aspire.Hosting" />
<PackageReference Include="KurrentDB.Client" />
<PackageReference Include="OpenTelemetry.Api" />
Co-authored-by: Copilot <copilot@github.com>
@afscrome
afscrome force-pushed the package-upgrades branch from 7b722ab to e670614 Compare May 4, 2026 20:36
afscrome and others added 2 commits May 4, 2026 22:17
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
@aaronpowell

Copy link
Copy Markdown
Member

All sorted as part of #1314

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants