Skip to content

chore: sync vendored Comfy Router spec (cloud@5a3b668) - #148

Open
comfy-pr-bot wants to merge 1 commit into
mainfrom
chore/sync-router-spec-5a3b668
Open

chore: sync vendored Comfy Router spec (cloud@5a3b668)#148
comfy-pr-bot wants to merge 1 commit into
mainfrom
chore/sync-router-spec-5a3b668

Conversation

@comfy-pr-bot

@comfy-pr-bot comfy-pr-bot commented Sep 14, 2026

Copy link
Copy Markdown
Member

Automated sync of the public Comfy Router spec,
projected from the canonical contract (internal notes stripped).
Source: cloud@5a3b668.

It lands at spec/router-openapi.yaml and is a contract of its
own — it is never merged into another vendored spec in this repo.

This PR is on its own per-source-commit branch (chore/sync-router-spec-5a3b668); a later
spec change opens a separate PR and will not touch this branch, so a
regen commit pushed here is safe.

No Router operations are currently unserved (as of cloud@5a3b668).

This note auto-refreshes while this PR is open: a change to comfy-api's
exclude list rewrites this section in place, and a change to the
PUBLISHED Router surface opens its own sync PR carrying the set as of
ITS commit. Once this PR is merged the note is a permanent snapshot —
for the current state, check services/comfy-api/drip/codegen.yaml in
Comfy-Org/cloud directly.

No code generation for this spec yet. Nothing in this repo
generates code from spec/router-openapi.yaml, so this sync has no low layer to
regenerate and the workflow that opened this pull request could not
prepare one for you.

That is not the same as nothing to do. This repo keeps a hand-written
surface coupled to this contract — its error-type class table — with
a drift check of its own, so a sync that adds an error bucket still
needs a commit here before this pull request goes green. When code
generation does land for this spec, its command is configured
upstream, in the same sync workflow that opened this PR, and this
section becomes the automatic one.

Summary by CodeRabbit

  • Documentation
    • Updated API documentation to describe model IDs consistently as {provider}/{model}.
    • Clarified model and provider path parameter descriptions by removing the optional variant suffix.

@coderabbitai

coderabbitai Bot commented Sep 14, 2026

Copy link
Copy Markdown

Review Change StackReview Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Advanced

Run ID: a5d733ee-5717-4a5a-90fe-0c3319569bc7

📥 Commits

Reviewing files that changed from the base of the PR and between fffd414 and 9e50418.

📒 Files selected for processing (1)
  • spec/router-openapi.yaml

Included review availability: Your plan provides up to 1 included review per hour; 0 remain after this review.


📝 Walkthrough

Walkthrough

The OpenAPI descriptions for router model IDs now use {provider}/{model} without the optional /{variant} suffix.

Changes

OpenAPI description update

Layer / File(s) Summary
Canonical model ID descriptions
spec/router-openapi.yaml
The RouterModelSegment, RouterProviderSegment, model, and provider descriptions now use {provider}/{model}.

Priority: ⬇️ Low

Estimated code review effort: 1 (Trivial) | ~3 minutes

Change: Other

Suggested reviewers: mattmillerai

Merge Risk: ⚪ Minimal · up to 9e504

This updates the OpenAPI documentation to match the supported two-segment model ID format without changing runtime behavior.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately identifies the change as a synchronization of the vendored Comfy Router specification from a specified source commit.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch chore/sync-router-spec-5a3b668

Comment @coderabbitai help to get the list of available commands.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants