Skip to content

[Feat] Search on App Settings Page - #710

Merged
neon-nyan merged 16 commits into
1.83.x-stagingfrom
feat/settings-search
Apr 2, 2025
Merged

neon-nyan merged 16 commits into
1.83.x-stagingfrom
feat/settings-search

Conversation

@bagusnl

@bagusnl bagusnl commented Mar 29, 2025 •

Copy link
Copy Markdown
Member

Main Goal

Add ability to do a search (string matching, not fuzzy) on collapse settings page

2025-04-02.20-41-07.webm

closes #709

PR Status :

  • Overall Status : Done
  • Commits : Done
  • Synced to base (Collapse:main) : Yes
  • Build status : OK
  • Crashing : Yes
  • Bug found caused by PR : 0

bagusnl and others added 8 commits March 29, 2025 06:43
Co-Authored-By: Bagus Nur Listiyono <28079733+bagusnl@users.noreply.github.com>
Co-Authored-By: Bagus Nur Listiyono <28079733+bagusnl@users.noreply.github.com>
@bagusnl bagusnl added Enhancement New feature or request Area: UI/UX Issue labeled for User Interface/eXperience related issue labels Mar 29, 2025
@bagusnl
bagusnl requested review from a team, neon-nyan and shatyuka March 29, 2025 10:13
@bagusnl bagusnl self-assigned this Mar 29, 2025
@bagusnl bagusnl linked an issue Mar 29, 2025 that may be closed by this pull request
@bagusnl bagusnl linked an issue Mar 29, 2025 that may be closed by this pull request
@bagusnl bagusnl added this to the 1.83.x milestone Mar 29, 2025
@github-actions

github-actions Bot commented Mar 29, 2025 •

Copy link
Copy Markdown

Qodana for .NET

It seems all right 👌

No new problems were found according to the checks applied

💡 Qodana analysis was run in the pull request mode: only the changed files were checked
☁️ View the detailed Qodana report

Contact Qodana team

Contact us at qodana-support@jetbrains.com

Comment thread CollapseLauncher/XAMLs/MainApp/Pages/SettingsPage.xaml.cs Fixed
@shatyuka

Copy link
Copy Markdown
Contributor

Can we add the ability to press Enter again to select the next matching item? And Shift+Enter to select the previous one.

  • The current highlighted color should be differentiated, such as orange.
  • The search button needs to be replaced with up and down arrows.

@bagusnl

bagusnl commented Mar 29, 2025

Copy link
Copy Markdown
Member Author

l'll need to check if AutoSuggestBox has controls for that. But I think the first one is doable, not sure about adding up/down arrows

Comment thread CollapseLauncher/Classes/Extension/UIElementExtensions.cs Fixed
Comment thread CollapseLauncher/Classes/Extension/UIElementExtensions.cs Fixed
Comment thread CollapseLauncher/Classes/Extension/UIElementExtensions.cs Fixed
Comment thread CollapseLauncher/XAMLs/MainApp/Pages/SettingsPage.xaml.cs Fixed
Comment thread CollapseLauncher/XAMLs/MainApp/Pages/SettingsPage.xaml.cs Fixed
@neon-nyan

Copy link
Copy Markdown
Member

Can we add the ability to press Enter again to select the next matching item? And Shift+Enter to select the previous one.

  • The current highlighted color should be differentiated, such as orange.
  • The search button needs to be replaced with up and down arrows.

@shatyuka On the recent commit, I added first iteration of the feature. The "current" highlighted color is Blue colored. Let me know if we need to change that to orange.

@sonarqubecloud

sonarqubecloud Bot commented Apr 2, 2025

Copy link
Copy Markdown

@neon-nyan neon-nyan left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The overall codebase has been reviewed. Some bug fix including RadioButton not getting indexed, has been pushed. Approved the changes

@neon-nyan

Copy link
Copy Markdown
Member

Will merge the PR as per convo internally. Waiting for the test to pass before merging

@neon-nyan
neon-nyan merged commit edab98e into 1.83.x-staging Apr 2, 2025
@neon-nyan
neon-nyan deleted the feat/settings-search branch April 2, 2025 15:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Area: UI/UX Issue labeled for User Interface/eXperience related issue Enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Request]: Settings Fuzzy Search

4 participants