Repository navigation
Make the site installable and add an Install app button - #286
Merged
Merged
Conversation
A web app manifest with 192 and 512 px icons (drawn from the logo) makes browsers offer "Install app" / "Add to Home screen". The homepage shows an Install app button while a Chromium browser offers its install prompt; a client module catches that event early, because it fires before React hydrates. Safari and Firefox never fire it, so no button appears there. No service worker: the installed app needs a connection, like the site.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes
static/manifest.webmanifest) with 192 and 512 px icons drawn from the logo, linked from every page. This is what makes browsers offer "Install app" / "Add to Home screen"; the site had none.beforeinstallprompt) and disappears once the prompt is used or the site is installed. Safari and Firefox never fire that event, so no button appears there.src/clientModules/installPrompt.ts) that catches the event as soon as the bundle runs, because it fires before React hydrates.Deliberately not included
No service worker: the installed app needs a connection, like the site itself.
How it was checked
npm run buildandtscpass.Page.getInstallabilityErrors) reports no errors for the built site.