Repository navigation
Conversation
A Trupp-Typ can be marked "Strahlenschutz" in the Stammdaten. A Trupp of that type copies the flag at registration, and every Einsatzkraft in it carries a record: OSL-Dosimeter, Alarmdosimeter, Maske and PA numbers, and the Alarmdosimeter's Ablesewert in mSv (default) or µSv, kept as read and never converted. - The row offers STRAHLENSCHUTZ, a dialog with one block per crew member, and an amber hint for what is still owed. - IM EINSATZ waits until both dosimeters of everyone are numbered or confirmed as nicht vorhanden. - "Nicht vorhanden" asks first, because it breaks the documentation chain, and writes an ACHTUNG line to the ETB. The Bericht prints it dark red. - The Ablesewert can follow after Abnehmen, since the Dekon-Platz reports late. Closing the Einsatz is refused, in the view model and in the domain, until every started Strahlenschutztrupp has one or a confirmed missing dosimeter per member. The incident schema moves to V46 (declared in SchemaGuard). A handed- over file and a host's snapshot are read leniently through RadiationRecord.FromUntrusted; a client's command is checked strictly. Protocol 45 adds recordScbaRadiation and radiationMonitoring on addScbaTrupp, which a host at 44 would drop, so the floor rises to 45. Closes #994 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Signed-off-by: Christian Arlt <c.arlt@gmx.de>
Contributor
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the
|
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #994. Stacked on #996 (both change the Trupp-Typ). Merge #996 first; this PR then retargets to
main.What changes
A Trupp-Typ can be marked Strahlenschutz in the Stammdaten. The Trupp copies the flag when it is registered, following the copy-at-use rule in AGENTS.md. Every Einsatzkraft in it then carries a record:
Atemschutz tab
ACHTUNG …line to the ETB, and the Bericht prints it dark red.Closing the Einsatz is refused while a started Strahlenschutztrupp still owes a reading. It is not merely warned about, because a closed Einsatz is read-only. The refusal names the Trupps, and its button leads to the Atemschutzüberwachung. The domain refuses too, since a client's close reaches the host as a command.
Bericht (PDF): one line per crew member with the numbers and the Ablesewert, offen or nicht vorhanden.
Schema, sync, trust boundaries
scba_trupps.radiation_monitoring, plushas_radiation, the number columns,dose_valueanddose_unitonscba_trupp_members. All are declared inSchemaGuard.ExpectedColumns.docs/samples/uebung.lagebuchwas regenerated.radiationMonitoringon a Trupp-Typ, covering JSON,md_trupp_types, the editor column,docs/master-data.example.json, the round-trip fixture anddocs/master-data.md. There is no automatic migration: which Trupp-Typ is under the Überwachung is the brigade's choice to tick.recordScbaRadiation.addScbaTruppcarriesradiationMonitoring. A host at 44 would drop it, registering the Trupp outside the Überwachung and letting the Einsatz close without its readings..lagebuchand a host snapshot are read leniently throughRadiationRecord.FromUntrusted. A number over 50 characters is cut, and an out-of-range reading or unknown unit is dropped, never fatal.Screenshots
Atemschutz: before, and after with Dosimeter-Nr. fehlen and IM EINSATZ held back.
Strahlenschutz dialog: numbers, Ablesewert with mSv, and the confirmation for nicht vorhanden.
Stammdaten → Trupp-Typen: the new STRAHLENSCHUTZ column.
Verification
LageBuch.Desktop.slnf(clean,rm bin/obj,restore --locked-mode,build,test): 0 warnings.AttachmentTempPathsTests×3,IncidentFileStoreTests×1). They test code this PR does not touch and fail on this Windows machine because it lacks the symlink privilege; they fail onmainthere too.mutate-diff: Domain 97 %, Documents 100 %, Persistence 100 %, AppLogic 96.8 %.First→FirstOrDefaultswaps on Trupps and members that always exist.{a..b}span globs match nothing on Windows, so whole changed files were mutated and scored on changed lines.make codeqlwas not run: the script supports Linux/macOS only. The diff was checked by hand against the AGENTS.md query table.🤖 Generated with Claude Code