Repository navigation
feat(lagemeldung): offer the "::" Textbausteine in the free-text fields - #985
Open
DeepDiver1975 wants to merge 1 commit into
Open
DeepDiver1975 wants to merge 1 commit into
DeepDiver1975 wants to merge 1 commit into
Conversation
Lage, Maßnahmen, Einheiten and Nachforderungen now take the same SnippetCompletion behaviour as the ETB composer. A sent Lagemeldung becomes an ETB entry, so the fields offer the ETB's list: the workspace hands SituationReportsViewModel the Etb view model's ForEtb-filtered TextSnippets, built at the same moment from the same Stammdaten. Meldender and Einsatzstelle are AutoCompleteBoxes; SnippetCompletion attaches to a TextBox only, so they stay as they are. Fixes #962 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Signed-off-by: Thomas Müller <1005065+DeepDiver1975@users.noreply.github.com>
Contributor
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 24 minutes. View limit details
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The
::Textbausteine now work in the Lagemeldung, as they do in the ETB and the Aufgaben.What changed and why
SituationReportsView.axaml: Lage, Durchgeführte Maßnahmen, Eingesetzte Einheiten and Nachforderungen getb:SnippetCompletion.Snippets="{Binding TextSnippets}", which is the same attached behaviour the ETB composer uses.SituationReportsViewModeltakes an optionalIReadOnlyList<TextSnippet> textSnippets(defaults to empty, likecallSigns/addresses) and exposes it asTextSnippets.IncidentWorkspaceViewModelpassesEtb.TextSnippets. A sent Lagemeldung becomes an ETB entry, so the fields offer the snippets ticked für ETB. This reuses the ETB'sForEtblist directly instead of filtering a second time, and it needs no new Stammdaten flag.MasterDataSet, so they cannot differ.SnippetCompletion(its tunnel handler marks it handled). The expansion setsTextBox.Text, the two-way binding updates the VM property, andFunkspruchPreviewfollows it. Leaving the field writes the draft through the existing LostFocus commit. An expansion that pushes a field past its 600-character cap shows the existing GermanError. It is not thrown.Not covered: Meldender (
ReporterBox) and Einsatzstelle (LocationBox) areAutoCompleteBoxes with their own suggestion lists.SnippetCompletionattaches to aTextBoxonly, so those two fields are unchanged. A comment in the view says so.Screenshots
Typing
Schuppen, ::fuinto Lage (fictional data):Tests
SituationReportsViewModelTests.The_lage_fields_offer_the_textbausteine_they_are_given_and_none_withoutIncidentWorkspaceViewModelTests.The_lagemeldung_offers_the_textbausteine_ticked_for_the_etbchecks that only theForEtbsnippets are offered, the same list asEtb.TextSnippets.SituationReportSnippetTests(headless, typed keys):::fu, and not the Aufgaben-only one;All of them failed before the change for the expected reason: a missing property, or no list offered.
Evidence (local)
make clean ci: every assembly reportsTest Run Successful, 0 warnings and 0 errors (Acceptance 1138/1138, AppLogic 3229/3229).make format-check: clean.make codeql: 0 results on changed lines, 0 elsewhere.make mutate PROJECT=AppLogic SINCE=origin/main: 100 % on changed lines (2 of 2 mutants killed).Fixes #962
🤖 Generated with Claude Code