Skip to content

feat(ils): two-stage Rückmeldung reminder with a spoken cross-platform cue - #82

Merged
DeepDiver1975 merged 4 commits into
mainfrom
feat/issue-70-ils-two-stage-timer-audio
Aug 18, 2026
Merged

DeepDiver1975 merged 4 commits into
mainfrom
feat/issue-70-ils-two-stage-timer-audio

Conversation

@DeepDiver1975

@DeepDiver1975 DeepDiver1975 commented Aug 18, 2026 •

Copy link
Copy Markdown
Contributor

Closes #70. Builds on the Stammdaten groundwork from #80 (the second ILS interval).

The ILS reminder becomes autonomous and two-stage, and gains a spoken audio cue.

Change

  • Autonomous reminder — the "Rückmeldung an ILS" reminder now auto-starts with
    the incident
    and runs the whole time; reporting back to the ILS is an ongoing
    obligation, so the manual START/STOPP buttons and the inline interval box are gone.
    The bar shows the live countdown, and FÄLLIG + ERLEDIGT when due. Intervals come
    from the Stammdaten settings (Erstmeldung nach / Intervall).
  • Two-stage timer — ReminderTimer.Start(clock, first, recurring): the first
    reminder is due after the Erstmeldung nach interval (default 15 min); every
    Acknowledge re-anchors and switches to the recurring Intervall (default 30 min).
  • Spoken cue — when a cycle falls due, the app speaks "Rückmeldung an ILS
    fällig"
    . IAlarmService gains a one-shot Play(AlarmSound) (enum currently just
    IlsReminderDue); the looping SCBA Rückzugsalarm (Start/Stop) is untouched.
    SystemAlarmService.Play is cross-platform — winmm one-shot on Windows, afplay
    on macOS, aplay on Linux — each guarded so a missing clip or absent player
    degrades to silence rather than crashing. Android stays a no-op.
  • Asset — bundled placeholder src/Feuerwehr.App/Assets/voice-rueckmeldung-ils.wav
    (16-bit PCM), picked up by the new Assets\*.wav glob. Swap in the final
    AI-generated clip anytime — no code change needed.

The Atemschutz spoken cues (Druckabfrage fällig and replacing the Rückzugsalarm
siren with speech) are split into #81, and will reuse this cross-platform
Play(...) path.

Testing

Non-Android suites pass (Domain 107, AppLogic 182, Acceptance 50, Sync.Hosting 21).
Coverage: two-stage timer cases + non-positive recurring-interval rejection; the
reminder auto-starts running at the first interval; the cue fires once per due cycle
and re-arms after acknowledge; the follow-up cycle uses the recurring interval.
FakeAlarmService gained Play recording without disturbing the SCBA IsSounding
assertions (no ScbaViewModelTests changes). Cross-platform playback
(afplay/aplay/winmm) is manual-verify — not unit-tested.

Screenshots

ILS reminder bar on a freshly started incident — before it required a manual start
(and a confusing STOPP), now it runs autonomously:

Before After
before after

🤖 Generated with Claude Code

DeepDiver1975 and others added 2 commits August 18, 2026 18:15
…m cue

Implements #70. The ILS reminder now alerts first after the "Erstmeldung nach"
interval (15) and then cyclically on the "Intervall" follow-up (30), and speaks
"Rückmeldung an ILS fällig" when a cycle falls due.

- ReminderTimer becomes two-stage: Start(clock, first, recurring) runs the first
  cycle at +first; Acknowledge re-anchors and switches to +recurring thereafter.
- IAlarmService gains a one-shot Play(AlarmSound) cue (enum: IlsReminderDue). The
  looping SCBA Rückzugsalarm (Start/Stop) is untouched. SystemAlarmService plays the
  cue cross-platform — winmm one-shot on Windows, afplay on macOS, aplay on Linux —
  each guarded so a missing clip or player degrades to silence. Android is a no-op.
- ReminderViewModel takes the recurring interval + IAlarmService and edge-triggers the
  cue once per due cycle; IncidentWorkspaceViewModel passes both settings intervals.
- Bundled voice clip src/Feuerwehr.App/Assets/voice-rueckmeldung-ils.wav (placeholder;
  Assets\*.wav glob picks it up).

The Atemschutz spoken cues (Druckabfrage fällig + replacing the Rückzugsalarm siren
with speech) are split into #81, reusing this cross-platform Play(...) path.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Signed-off-by: Thomas Müller <1005065+DeepDiver1975@users.noreply.github.com>
The reminder was built as a manually-started, stoppable timer, so after a new
incident it sat idle until "TIMER STARTEN" was pressed, and the STOPP button let you
drop back to a fresh 15-min start — both confusing, since reporting back to the ILS
is an ongoing obligation for the whole incident.

- ReminderViewModel now auto-starts the timer in its constructor (it is only built
  for live authoritative sessions) and drops the Start/Stop commands.
- The ILS bar loses the interval box and the START/STOPP buttons; intervals come from
  the Stammdaten settings. It shows the live countdown, and FÄLLIG + ERLEDIGT when due.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Signed-off-by: Thomas Müller <1005065+DeepDiver1975@users.noreply.github.com>
DeepDiver1975 added a commit that referenced this pull request Aug 18, 2026
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Signed-off-by: Thomas Müller <1005065+DeepDiver1975@users.noreply.github.com>
DeepDiver1975 and others added 2 commits August 18, 2026 21:29
The acknowledged 'Rückmeldung an ILS' entry was logged with from: null, so the ETB
'Von' field was empty. It should carry the logged-in operator's call sign (the ELW's
Funkrufname), matching how status-change entries record their originator.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Signed-off-by: Thomas Müller <1005065+DeepDiver1975@users.noreply.github.com>
Replace the placeholder WAV with the transcoded ElevenLabs recording
('Rückmeldung an ILS fällig', North German voice). Transcoded MP3 → 16-bit PCM mono
22050 Hz so it plays through winmm (Windows) and aplay (Linux), which the source MP3
would not. No code change — the Assets\*.wav glob and the cue→file mapping already
reference this filename.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Signed-off-by: Thomas Müller <1005065+DeepDiver1975@users.noreply.github.com>
@DeepDiver1975
DeepDiver1975 merged commit 3dfc88c into main Aug 18, 2026
2 checks passed
@DeepDiver1975
DeepDiver1975 deleted the feat/issue-70-ils-two-stage-timer-audio branch August 18, 2026 20:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

ILS timer ...

1 participant