Skip to content

fix(masterdata): align checklist mandatory header - #802

Open
Saad-elnagar wants to merge 1 commit into
CodeForFire:mainfrom
Saad-elnagar:fix/issue-714-checklist-header-alignment
Open

Saad-elnagar wants to merge 1 commit into
CodeForFire:mainfrom
Saad-elnagar:fix/issue-714-checklist-header-alignment

Conversation

@Saad-elnagar

Copy link
Copy Markdown

Summary

Fixes #714

Align the PFLICHT header with the mandatory checkbox column in the checklist template editor to ensure consistent column alignment between the header and checklist rows.

Changes

  • Enabled shared column sizing for the checklist template header and rows.
  • Matched the widths of the mandatory checkbox and row action columns.
  • Added a changelog entry describing the UI fix.

Checklist

  • Commit follows Conventional Commits and includes a DCO sign-off.
  • Commit is cryptographically signed (SSH or GPG) and shows as Verified on GitHub.
  • dotnet build and dotnet test pass locally.
  • Added one English changelog entry in changelog.d/.
  • UI changes include before/after screenshots.
  • No real master data or personnel data committed.

Signed-off-by: Saad Elnager <222959247+Saad-elnagar@users.noreply.github.com>
@DeepDiver1975

Copy link
Copy Markdown
Contributor

@claude review

@claude

claude Bot commented Oct 28, 2026 •

Copy link
Copy Markdown

Claude finished @DeepDiver1975's task in 17s —— View job


Review of #802: align checklist mandatory header

I read the diff only. I did not build the project or render the view.

Verdict: The approach is sound, and I found no blocking issues. Two process items from the PR checklist are still open.

Code

  • Fix: MasterDataEditorView.axaml gives the header and the row Grids the same SharedSizeGroup names. It sets Grid.IsSharedSizeScope="True" on the enclosing DockPanel. This is the pattern AGENTS.md prescribes for ragged Auto columns inside an ItemsControl. The header's PFLICHT column now takes the width of the row's Pflicht checkbox plus its 6px margin. The left-aligned PFLICHT text should line up with the checkbox.
  • Scope: The scope sits on the template root. Each section (Aufbau, Abbau) gets its own scope, so the two editors do not size each other.
  • Empty header columns: Columns 2–4 hold no header content but are still declared in the groups. This is intentional: it keeps the * column the same width in both grids. Without them the text column would drift.
  • Compiled bindings: x:DataType is unchanged and there are no new bindings.
  • Changelog: The entry is one English sentence, uses the right file name, and links no PR. That matches the rules.
  • Android: SharedSizeGroup is part of Avalonia's core Grid, so nothing here is desktop-only.

Open items

  1. Screenshots: The checklist leaves "UI changes include before/after screenshots" unchecked, and AGENTS.md requires them for any UI PR. Render the editor with the headless harness (WorkspaceRenderHelper and CaptureRenderedFrame()) and attach before/after PNGs with gh pr edit 802 --attach.
  2. Signing: The commit is not marked as cryptographically signed. main's branch protection rejects unsigned commits, so re-sign it with -S -s. Check with git cat-file commit HEAD | grep gpgsig.
  3. Build and tests: Run make clean ci and confirm it passes. AGENTS.md says XAML problems surface only on a full rebuild.
  4. Minor, optional: A small [AvaloniaFact] test would stop this regressing. It would check that the header PFLICHT block and the first row's CheckBox have the same X offset. Per the repo rules, find the controls by x:Name and compare with a tolerance, not ==. This is not required for merge.

@DeepDiver1975

Copy link
Copy Markdown
Contributor

@Saad-elnagar are you planning to return and finish this PR? Thank you very much!

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Stammdaten: in the Checkliste editor the PFLICHT header is not aligned with its column

2 participants