Repository navigation
feat(einsatzdaten): add Hausnummer, PLZ and Ort to the address - #727
Merged
Merged
Conversation
An incident's location was Straße and Ortsteil only, so an Einsatz in überörtlicher Hilfe had nowhere to put the Ort and the house number lived inside the street by convention. - Incident gains HouseNumber, PostalCode and Place; every part stays optional, so the one-Gemeinde workflow is unchanged. - Formatting.Address joins "Straße Hausnr., Ortsteil, PLZ Ort" with blank parts dropped; the header, the PDF and the join prompt use it. - Migration V26 adds the three incident_meta columns (declared in SchemaGuard); older files open with them blank. - setAddress and the snapshot carry the new fields. A client at protocol 7 would send setAddress without them and clear what another device entered, so ProtocolVersion and MinimumProtocolVersion rise to 8. - The Einsatzdaten dialog gets HAUSNR., PLZ and ORT fields. Fixes #401 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Signed-off-by: Thomas Müller <1005065+DeepDiver1975@users.noreply.github.com>
SchemaGuard.Reconcile adds the same three nullable incident_meta columns on every open, so no test can observe V26 being skipped or mutated. CONTRIBUTING.md says to silence such mutants where they stand with the reason rather than write a test for them. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Signed-off-by: Thomas Müller <1005065+DeepDiver1975@users.noreply.github.com>
6 tasks done
The dialog screenshot kept the house number inside the street and paired Ortsteil FFB with Fürstenfeldbruck; other fixtures paired Puch with Petershausen. Every fixture and the ORT and PLZ placeholders now read Hauptstr. 12, Puch, 82256 Fürstenfeldbruck, with the house number in its own field. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Signed-off-by: Thomas Müller <1005065+DeepDiver1975@users.noreply.github.com>
This was referenced Oct 22, 2026
This was referenced Oct 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
An incident's address held only Straße and Ortsteil. In überörtlicher Hilfe, or on a Landkreis-level ELW, there was nowhere to put the Ort, and the Hausnummer lived inside the street by convention. This PR adds Hausnummer, PLZ and Ort. All three are optional, so the one-Gemeinde workflow still needs only two fields.
District(Ortsteil) stays its own field, as the issue proposes.Fixes #401
Changes
IncidentgainsHouseNumber,PostalCodeandPlace.SetAddresstakes them as optional trailing parameters, so existing two-argument callers keep their meaning.Formatting.Addressjoins the parts in German postal order — „Straße Hausnr., Ortsteil, PLZ Ort“ — and drops blank parts.Hauptstr. 12, FFB) is unchanged.Address(Incident)overload feeds the workspace header, the PDF header and the join prompt.incident_meta.house_number,postal_codeandplaceas nullable columns, declared inSchemaGuard.ExpectedColumns. A V25 file opens with them blank and its existing address intact (tested).setAddressandIncidentSnapshotcarry the new fields.ProtocolVersionandMinimumProtocolVersionboth rise to 8. A peer at 7 cannot simply ignore the new fields: a 7 client sendssetAddresswithout them, and an 8 host reads that as "cleared", wiping what another device entered.Screenshots
Before:
After:
Checklist
git commit -s)dotnet buildanddotnet testpass locally (make clean ci: 8/8 test assemblies green, 0 warnings;make format-checkclean)src/add one changelog entry inchangelog.d/docs/samples/uebung.fwincidentand the README screenshots are left for the milestone refresh, as usual.🤖 Generated with Claude Code