Skip to content

feat(sync): ask before stopping sharing - #628

Merged
DeepDiver1975 merged 1 commit into
mainfrom
feat/604-confirm-stop-sharing
Oct 17, 2026
Merged

DeepDiver1975 merged 1 commit into
mainfrom
feat/604-confirm-stop-sharing

Conversation

@DeepDiver1975

@DeepDiver1975 DeepDiver1975 commented Oct 17, 2026 •

Copy link
Copy Markdown
Contributor

Fixes #604

What

While an Einsatz is shared, the small icon-only ✕ next to the PIN button stopped sharing at once and cut off every joined device. Leaving the incident already asks first (ConfirmLeaveThen). Stopping sharing has the same impact on the rest of the team and now asks too:

Freigabe beenden? Verbundene Geräte werden getrennt. — ABBRECHEN / BEENDEN

This is the existing ConfirmDialogViewModel, so the #545 keyboard contract comes for free: focus lands on ABBRECHEN, and Enter activates the focused button.

Different from the plan: it always asks

#604 suggests skipping the confirm when no device is connected. The host doesn't know that today: nothing counts hub connections, and IIncidentHostController has no peer count. Adding that across the hub, the controller, its interface and the test doubles just to skip one dialog is more plumbing than the fix itself. Stopping sharing is rare, so one extra click when nobody is connected is cheap. The issue marks the skip as optional.

Screenshots

Both show the state right after clicking the ✕ while sharing.

Before After
Before: sharing stopped immediately After: confirm dialog, focus on ABBRECHEN

Tests

  • Stopping_sharing_asks_first_and_keeps_the_host_running_until_confirmed, Cancelling_the_stop_keeps_sharing (view model).
  • Clicking_the_stop_button_asks_before_ending_the_share (headless, through the real button). It fails without the change, and it's also the source of the screenshots.
  • Two existing tests that stopped sharing now confirm explicitly.

make clean ci and make format-check pass.

🤖 Generated with Claude Code

The ✕ beside the share info is a small icon target next to another
icon button, and stopping disconnects every joined device mid-Einsatz.
Leaving the incident already asks first; stopping sharing now does too,
with the same "Freigabe beenden?" dialog (focus on ABBRECHEN).

Fixes #604

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Signed-off-by: Thomas Müller <1005065+DeepDiver1975@users.noreply.github.com>
@DeepDiver1975
DeepDiver1975 merged commit 6b0de06 into main Oct 17, 2026
6 checks passed
@DeepDiver1975
DeepDiver1975 deleted the feat/604-confirm-stop-sharing branch October 17, 2026 22:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Stopping sharing disconnects every joined device without a confirm

1 participant