Repository navigation
feat(sync): ask before stopping sharing - #628
Merged
Merged
Conversation
The ✕ beside the share info is a small icon target next to another icon button, and stopping disconnects every joined device mid-Einsatz. Leaving the incident already asks first; stopping sharing now does too, with the same "Freigabe beenden?" dialog (focus on ABBRECHEN). Fixes #604 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Signed-off-by: Thomas Müller <1005065+DeepDiver1975@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #604
What
While an Einsatz is shared, the small icon-only ✕ next to the PIN button stopped sharing at once and cut off every joined device. Leaving the incident already asks first (
ConfirmLeaveThen). Stopping sharing has the same impact on the rest of the team and now asks too:This is the existing
ConfirmDialogViewModel, so the #545 keyboard contract comes for free: focus lands on ABBRECHEN, and Enter activates the focused button.Different from the plan: it always asks
#604 suggests skipping the confirm when no device is connected. The host doesn't know that today: nothing counts hub connections, and
IIncidentHostControllerhas no peer count. Adding that across the hub, the controller, its interface and the test doubles just to skip one dialog is more plumbing than the fix itself. Stopping sharing is rare, so one extra click when nobody is connected is cheap. The issue marks the skip as optional.Screenshots
Both show the state right after clicking the ✕ while sharing.
Tests
Stopping_sharing_asks_first_and_keeps_the_host_running_until_confirmed,Cancelling_the_stop_keeps_sharing(view model).Clicking_the_stop_button_asks_before_ending_the_share(headless, through the real button). It fails without the change, and it's also the source of the screenshots.make clean ciandmake format-checkpass.🤖 Generated with Claude Code