Repository navigation
test(keyboard): keyboard-only Übung walkthrough and keystroke budget (#545) - #568
Merged
Merged
Conversation
…545) Closes out the testable part of the keyboard epic's "Done when" list. - KeyboardWalkthroughTests drives a whole Übung from Home to the PDF with key presses only: new incident, Kräfte, an Atemschutz Trupp with its Druckkontrolle via F9, two ETB entries, an Aufgabe and the export. - KeystrokeBudgetTests counts three everyday flows and pins them as budgets: one ETB entry 4 keys, one Druckkontrolle 2, one vehicle 3. Before v0.8 the first and last were not possible without the mouse, because Tab never reached the module rail; the Druckkontrolle took 26. - ShellHarness and CountingKeyboard are shared by both; ExportablePdf moves out of OverlayContractTests so the walkthrough can export too. The walkthrough found one gap: the PDF dialog opened with focus on the first section checkbox, so Enter unticked the Checkliste instead of exporting. It now opens on EXPORTIEREN, as the overlay contract says. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Signed-off-by: Thomas Müller <1005065+DeepDiver1975@users.noreply.github.com>
13 of 14 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #545 (keyboard-only operation). This covers the testable items of the epic's Done when list. The Übung with real Lagebuchführer stays open, so this does not close the epic.
What it adds
KeyboardWalkthroughTests: one Übung from Home to the PDF, by key presses alone. NEUER EINSATZ → Lagebuchführer prompt → a vehicle in Kräfte → an Atemschutz Trupp sent in → its Druckkontrolle via F9 → two ETB entries via Strg+N → an Aufgabe → PDF EXPORTIEREN. The test sets no view model property and runs no command, and no pointer event is involved.KeystrokeBudgetTests: three everyday flows, counted in keys spent getting there (typed text excluded), pinned as budgets so they can only go down:3b4f24d)Before v0.8, Tab never reached the module rail, so switching modules needed the mouse.
ShellHarnessandCountingKeyboard: shared by both.ExportablePdfmoves out ofOverlayContractTestsso the walkthrough can export too.The gap the walkthrough found
The PDF options dialog opened with focus on the first section checkbox (Checkliste). Enter on a checkbox toggles it, so a reflex Enter left the Checkliste out of the Bericht instead of exporting. Contract 1 says Enter triggers the primary action. The dialog now opens on EXPORTIEREN (
b:Overlay.InitialFocus), andThe_pdf_dialog_opens_on_EXPORTIEREN_so_Enter_exports_every_sectionholds the line.Checks
make clean ci: 0 errors, all 8 test assemblies pass (Acceptance 528).make format-checkclean.🤖 Generated with Claude Code