Skip to content

test(keyboard): keyboard-only Übung walkthrough and keystroke budget (#545) - #568

Merged
DeepDiver1975 merged 1 commit into
mainfrom
test/545-keyboard-walkthrough
Oct 6, 2026
Merged

DeepDiver1975 merged 1 commit into
mainfrom
test/545-keyboard-walkthrough

Conversation

@DeepDiver1975

Copy link
Copy Markdown
Contributor

Part of #545 (keyboard-only operation). This covers the testable items of the epic's Done when list. The Übung with real Lagebuchführer stays open, so this does not close the epic.

What it adds

  • KeyboardWalkthroughTests: one Übung from Home to the PDF, by key presses alone. NEUER EINSATZ → Lagebuchführer prompt → a vehicle in Kräfte → an Atemschutz Trupp sent in → its Druckkontrolle via F9 → two ETB entries via Strg+N → an Aufgabe → PDF EXPORTIEREN. The test sets no view model property and runs no command, and no pointer event is involved.

  • KeystrokeBudgetTests: three everyday flows, counted in keys spent getting there (typed text excluded), pinned as budgets so they can only go down:

    Flow Before v0.8 (3b4f24d) After
    One ETB entry from another module not possible without the mouse (1 click + 5 keys) 4
    One Druckkontrolle from the warning bar 26 2
    One vehicle in Kräfte from another module not possible without the mouse (1 click + 11 keys) 3

    Before v0.8, Tab never reached the module rail, so switching modules needed the mouse.

  • ShellHarness and CountingKeyboard: shared by both. ExportablePdf moves out of OverlayContractTests so the walkthrough can export too.

The gap the walkthrough found

The PDF options dialog opened with focus on the first section checkbox (Checkliste). Enter on a checkbox toggles it, so a reflex Enter left the Checkliste out of the Bericht instead of exporting. Contract 1 says Enter triggers the primary action. The dialog now opens on EXPORTIEREN (b:Overlay.InitialFocus), and The_pdf_dialog_opens_on_EXPORTIEREN_so_Enter_exports_every_section holds the line.

Before After
Before After

Checks

  • make clean ci: 0 errors, all 8 test assemblies pass (Acceptance 528).
  • make format-check clean.

🤖 Generated with Claude Code

…545)

Closes out the testable part of the keyboard epic's "Done when" list.

- KeyboardWalkthroughTests drives a whole Übung from Home to the PDF
  with key presses only: new incident, Kräfte, an Atemschutz Trupp with
  its Druckkontrolle via F9, two ETB entries, an Aufgabe and the export.
- KeystrokeBudgetTests counts three everyday flows and pins them as
  budgets: one ETB entry 4 keys, one Druckkontrolle 2, one vehicle 3.
  Before v0.8 the first and last were not possible without the mouse,
  because Tab never reached the module rail; the Druckkontrolle took 26.
- ShellHarness and CountingKeyboard are shared by both; ExportablePdf
  moves out of OverlayContractTests so the walkthrough can export too.

The walkthrough found one gap: the PDF dialog opened with focus on the
first section checkbox, so Enter unticked the Checkliste instead of
exporting. It now opens on EXPORTIEREN, as the overlay contract says.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Signed-off-by: Thomas Müller <1005065+DeepDiver1975@users.noreply.github.com>
@DeepDiver1975 DeepDiver1975 mentioned this pull request Oct 6, 2026
13 of 14 tasks
@DeepDiver1975
DeepDiver1975 merged commit 3ed9cd3 into main Oct 6, 2026
6 checks passed
@DeepDiver1975
DeepDiver1975 deleted the test/545-keyboard-walkthrough branch October 6, 2026 14:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant