Repository navigation
docs(agents): add CodeQL's useless type test to the static-analysis traps - #556
Merged
Merged
Conversation
…raps The build does not warn about a pattern match against a type the value already has, so it only surfaces as a code-scanning alert on the pull request, as it did on #555 (Visual is always an ILogical). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Signed-off-by: Thomas Müller <1005065+DeepDiver1975@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds one bullet to AGENTS.md › Static analysis: never type-test a value against a type it already is (
cs/useless-type-test).The build doesn't catch this: no compiler or analyzer warning, so
make clean cipasses, and the alert only shows up from code scanning on the pull request. That happened on #555, wherevisual is ILogical logicalwas always true because every AvaloniaVisualis anILogical. The bullet names that case and gives the quick proof: delete the test and build.Docs only, so no changelog entry.
🤖 Generated with Claude Code