Repository navigation
feat(home): restrict PIN join field to digits - #277
Merged
Merged
Conversation
The join-by-PIN TextBox accepted any character, capped only at 4 by MaxLength -- easy to mistype under time pressure (#262 UX review). Apply the existing IntegerOnly attached behavior (already used for Forces' count fields, #76) so a paste or keystroke containing a non-digit is refused wholesale rather than silently accepted or mutilated. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01R9oidCyJ6YmhtCxu9WxGKo Signed-off-by: Thomas Müller <1005065+DeepDiver1975@users.noreply.github.com>
34 of 53 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
TextBox, capped at 4 characters only viaMaxLength, with no digit-only filtering -- easy to mistype under time pressure.IntegerOnlyattached behavior (already used for Forces' count fields since kräfte #76) toPinBoxinOperatorPromptView.axaml. A keystroke or paste containing any non-digit character is refused wholesale, same contract as elsewhere in the app -- no new control invented.Test plan
dotnet test tests/LageBuch.Acceptance.Tests-- 137 passed, 1 pre-existing skip, 0 faileddotnet test tests/LageBuch.AppLogic.Tests --filter OperatorPromptViewModelTests-- 20 passedJoinPromptRenderTests.cs:Non_digit_characters_are_refused_in_the_pin_field(theory: letter, punctuation, all-letters),Digit_entry_still_goes_through_the_pin_field, plusJoin_prompt_shows_a_pin_fieldnow also assertsIntegerOnly.GetIsEnabled🤖 Generated with Claude Code
https://claude.ai/code/session_01R9oidCyJ6YmhtCxu9WxGKo