Skip to content

feat(home): restrict PIN join field to digits - #277

Merged
DeepDiver1975 merged 1 commit into
mainfrom
feat/home-pin-digits-262
Sep 9, 2026
Merged

DeepDiver1975 merged 1 commit into
mainfrom
feat/home-pin-digits-262

Conversation

@DeepDiver1975

Copy link
Copy Markdown
Contributor

Summary

  • Home / Start screen UX finding from UX review: findings and follow-ups #262: the join-by-PIN field was a plain unmasked TextBox, capped at 4 characters only via MaxLength, with no digit-only filtering -- easy to mistype under time pressure.
  • Applies the existing IntegerOnly attached behavior (already used for Forces' count fields since kräfte #76) to PinBox in OperatorPromptView.axaml. A keystroke or paste containing any non-digit character is refused wholesale, same contract as elsewhere in the app -- no new control invented.

Test plan

  • dotnet test tests/LageBuch.Acceptance.Tests -- 137 passed, 1 pre-existing skip, 0 failed
  • dotnet test tests/LageBuch.AppLogic.Tests --filter OperatorPromptViewModelTests -- 20 passed
  • New tests in JoinPromptRenderTests.cs: Non_digit_characters_are_refused_in_the_pin_field (theory: letter, punctuation, all-letters), Digit_entry_still_goes_through_the_pin_field, plus Join_prompt_shows_a_pin_field now also asserts IntegerOnly.GetIsEnabled
  • Before/after screenshots attached (typing "12ab" into an empty PIN field)

before
after

🤖 Generated with Claude Code

https://claude.ai/code/session_01R9oidCyJ6YmhtCxu9WxGKo

Before

After

The join-by-PIN TextBox accepted any character, capped only at 4 by
MaxLength -- easy to mistype under time pressure (#262 UX review). Apply
the existing IntegerOnly attached behavior (already used for Forces'
count fields, #76) so a paste or keystroke containing a non-digit is
refused wholesale rather than silently accepted or mutilated.

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01R9oidCyJ6YmhtCxu9WxGKo
Signed-off-by: Thomas Müller <1005065+DeepDiver1975@users.noreply.github.com>
@DeepDiver1975
DeepDiver1975 merged commit 93f877e into main Sep 9, 2026
2 checks passed
@DeepDiver1975
DeepDiver1975 deleted the feat/home-pin-digits-262 branch September 9, 2026 06:57
@DeepDiver1975 DeepDiver1975 mentioned this pull request Oct 16, 2026
34 of 53 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant