Skip to content

Stammdaten: a personnel row without a Nachname is silently dropped on save #650

Closed

Description

@DeepDiver1975

Split out of the UX review #262.

Problem

In the Stammdaten editor, a personnel row whose Nachname is empty is skipped when the list is turned into Persons (PersonnelSection.cs:57-61):

var last = r.LastName?.Trim() ?? string.Empty;
if (last.Length == 0)
{
    continue;

That list feeds Personnel = _personnel.ToPeople() (MasterDataEditorViewModel.cs:293). SPEICHERN reports success, and the row — Vorname, phone, Funkrufname, e-mail and all — is gone the next time the editor opens. Nothing on screen says so. Someone entering a new Einsatzkraft who fills the Vorname first and moves on loses the whole row.

Expected

  • A row that has any field filled but no Nachname is a conflict, raised in RefreshPersonnelConflicts the same way the e-mail conflict is: the banner names the row (e.g. "Person ohne Nachname: Zeile 4") and SPEICHERN stays disabled until it is fixed.
  • A completely empty row may still be dropped silently; that is an untouched blank, not data.

Notes

  • Bug fix: write the failing test first — fill only the Vorname, assert SPEICHERN is blocked and the conflict text names the row.
  • This touches the UI, so the PR needs a before/after screenshot pair.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't workinguxUser interface and usability

    Type

    No type

    Projects

    No projects

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions