You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Raw exception messages leak into German UI text and across the sync wire #602
Many user-facing error strings append the raw exception message to German text, and some show only the exception message. That text is often English, technical, or both (socket errors, HttpRequestException, BCL argument messages). An ELW crew reads "Verbindung zu 192.168.1.20 nicht möglich … (No route to host)". Worse, this text crosses the sync trust boundary: the host sends internal exception text to peers.
Launchers:UrlLauncher.cs:50, ContactLauncher.cs:44, :69. These surface in Links, Kontakte and Über.
Expected
Every user-visible failure is a German sentence that says what failed and what to do. The exception type picks the sentence, never its message.
Typed exceptions that already carry German text (e.g. CertificateChangedException) may keep using it. Make that an explicit allowlist, not a fallthrough.
The host answers a rejected command with a fixed, non-revealing reason, or a small closed set of reason codes the client maps to German. It never sends ex.Message.
AGENTS.md: "Personal data stays out of diagnostics". An exception message can carry a file path or a name, which is another reason not to echo it.
Notes
A security-relevant part gets a test that replays it: a peer sends a command that triggers an ArgumentException, and the response body must not contain the exception text.
The sync part is not a leak. The domain guards throw German sentences on purpose (RoleAssignment, EtbEntry, ForceUnit, …). The ex.Message the host returns at IncidentHost.cs:325 is therefore mostly the same German sentence the local UI shows for the same mistake. The peer receiving it has already passed the PIN and sees the whole incident. The one real wart is KeyNotFoundException, whose text can be English BCL wording.
A blanket "the exception type picks the sentence" rewrite would cost something. With no log file (see #300), ex.Message is the only diagnostic the app has. "Access to the path … is denied" or "No space left on device" is what tells someone what to fix. Replacing it everywhere with a generic sentence makes field problems harder to diagnose.
What this issue will do:
Sites that show onlyex.Message, with no German framing, get a German sentence saying what failed, with the detail kept after it: FilesViewModel (ErrorMessage = ex.Message) and the join errors in HomeViewModel.
The host maps KeyNotFoundException to a fixed German reason instead of the BCL text, with a test replaying a command against an unknown id.
Dropped: the allowlist machinery and the rewrite of sites that already carry German framing.
Activity
DeepDiver1975 commentedon Oct 17, 2026
Rescoping before implementation.
The sync part is not a leak. The domain guards throw German sentences on purpose (
RoleAssignment,EtbEntry,ForceUnit, …). Theex.Messagethe host returns atIncidentHost.cs:325is therefore mostly the same German sentence the local UI shows for the same mistake. The peer receiving it has already passed the PIN and sees the whole incident. The one real wart isKeyNotFoundException, whose text can be English BCL wording.A blanket "the exception type picks the sentence" rewrite would cost something. With no log file (see #300),
ex.Messageis the only diagnostic the app has. "Access to the path … is denied" or "No space left on device" is what tells someone what to fix. Replacing it everywhere with a generic sentence makes field problems harder to diagnose.What this issue will do:
ex.Message, with no German framing, get a German sentence saying what failed, with the detail kept after it:FilesViewModel(ErrorMessage = ex.Message) and the join errors inHomeViewModel.KeyNotFoundExceptionto a fixed German reason instead of the BCL text, with a test replaying a command against an unknown id.Dropped: the allowlist machinery and the rewrite of sites that already carry German framing.
🤖 Generated with Claude Code