Skip to content

Atemschutz: a double-click on RÜCKZUG also triggers ABGENOMMEN, and neither can be undone #601

Closed

Description

@DeepDiver1975

Split out of the UX review #262. This is safety-critical: it can end the monitoring of a crew without anyone meaning to.

Problem

In the Atemschutz grid and the cards, an active Trupp shows [Druck] [DRUCK] [RÜCKZUG]. Once RÜCKZUG is clicked, the row immediately shows [Druck] [DRUCK] [ABGENOMMEN]. ABGENOMMEN lands in exactly the slot RÜCKZUG just left, with the same signal style (ScbaView.axaml:393-402, cards :525-534).

A double-click on RÜCKZUG therefore withdraws the Trupp and marks it removed in one gesture. Its monitoring ends: the timer stops, it leaves the alarm set, and two ETB lines are written.

None of the state transitions (IM EINSATZ, RÜCKZUG, ABGENOMMEN) asks for confirmation or offers an undo. Withdraw() and MarkRemoved() call straight through to the session (ScbaViewModel.cs:229-237, :1069-1094). The app already has an undo notice, OfferUndo / UndoNoticeViewModel with Strg+Z (#543), but only ticking off an Aufgabe uses it. ScbaViewModel is constructed without it.

Expected

  • A double-click on RÜCKZUG must never also trigger ABGENOMMEN.
  • ABGENOMMEN, which ends monitoring, is deliberately confirmed or can be undone. Follow the keyboard contract in epic: keyboard-only operation (tracking) #545:
    • a destructive confirm focuses ABBRECHEN;
    • or a "Rückgängig" notice with Strg+Z, the way Aufgaben do.
  • RÜCKZUG is time-critical and must stay one action. An undo notice fits it better than a dialog.

Notes

  • Write the failing test first. A headless test should replay two clicks on the RÜCKZUG button's position within the double-click interval, then assert the Trupp is still withdrawing and still monitored.
  • ETB entries are a record. An undo should either suppress the ETB line until the notice expires or write a correcting line. Decide which in the PR.
  • Related: ux(atemschutz): add tooltips to the five ScbaView state-transition buttons #346 (tooltips on these buttons).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't workinguxUser interface and usability

    Type

    No type

    Projects

    No projects

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions