Skip to content

feat(input): Enter submits every entry form and focus returns to the first field #540

Closed

Description

@DeepDiver1975

Part of #545 (keyboard-only operation, v0.8).

Today

"Enter submits" only holds in some places, so the Lagebuchführer can't rely on it:

View Enter submits from No Enter in
ETB VON, AN, EINTRAG (EtbView.axaml:134,140,147) —
Kräfte FEUERWEHR, FUNKRUFNAME (ForcesView.axaml:205,219) Stärke, AGT, BEMERKUNG (:229-248); the whole vehicle path: once a FAHRZEUG is picked, both Enter fields are disabled (:201,215)
Atemschutz the three crew boxes (ScbaView.axaml:153,162,171) FUNKRUFNAME (:129), TRUPP-ART, the NumericUpDowns (:176,186,193)
Rollen NAME (RolesView.axaml:158) FUNKTION, ABSCHNITT, FUNKRUFNAME, HANDYNUMMER (:143-176)
Aufgaben ZUGETEILT, TIMER, AUFGABE (TasksView.axaml:159,166,175) —
Beteiligte all three fields —
  • After a submit, focus never goes back to the first field. ETB clears VON/AN/EINTRAG (EtbViewModel.cs:260-262) but leaves focus in EINTRAG, so every repeated entry costs Shift+Tab ×2.
  • Initial focus is inconsistent:
    • ETB starts in EINTRAG, not VON (EtbView.axaml.cs:13).
    • Kräfte starts in BrigadeBox (ForcesView.axaml.cs:10), which comes after VehicleBox (:174).
    • Atemschutz starts in TRUPPFÜHRER (ScbaView.axaml.cs:25), below FUNKRUFNAME and TRUPP-ART.
    • Aufgaben, Beteiligte and Links set no initial focus at all.

Proposal

  • Every single-line field in an entry form submits on Enter, using the existing KeyBinding for TextBoxes and the EnterSubmit behaviour for suggestion boxes. Multi-line fields are the exception.
  • After a successful submit, focus goes to the form's first field. Fields this issue marks sticky keep their value with the text selected (typing replaces it, Tab keeps it); everything else is cleared. Candidates to decide here: Kräfte FEUERWEHR (several vehicles from one Feuerwehr in a row) and ETB VON (a run of messages from one unit). Write down per view which fields are sticky, or that none are. After a failed submit (validation), focus goes to the first field that is invalid (see feat(ux): Pflichtfelder kennzeichnen (Sternchen oder Farbe) #414).
  • A view's initial focus is its first field in visual order, unless the issue for that view says otherwise. Coordinate with fix(focus): focus stays where the user left it (rail, sync rebuilds, reconnect, ETB filter) #542: no auto-focus when the view is reached by arrowing the rail.
  • ETB starts in EINTRAG today. Moving it to VON changes a habit people already have, so decide it here explicitly and give the reason. Don't let it just follow from the rule.

Acceptance

  • Per view, a headless test: fill in the form by keyboard, Enter from the last field submits, focus is on the first field.
  • Kräfte: the vehicle path submits on Enter.
  • ETB: three entries in a row without touching Shift+Tab.
  • Kräfte: two vehicles from the same Feuerwehr without retyping FEUERWEHR (if it is sticky).

Android: Enter from the soft keyboard ("Done"/"Go") now submits in more places. Check that this is wanted on the phone layout.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    enhancementNew feature or requestuxUser interface and usability

    Type

    No type

    Projects

    No projects

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions