Skip to content

ux(dateien): add an empty-state message to FilesView #347

Closed

Description

@DeepDiver1975

The Dateien tab shows an empty bordered table when an incident has no
attachments. There is no sentence telling the user that this is normal and what
to do about it.

LinksView already solves exactly this, and it is three lines. From
src/LageBuch.App.Shared/Views/LinksView.axaml line 52:

<TextBlock DockPanel.Dock="Top" x:Name="EmptyText" Text="Keine Links hinterlegt."
           Foreground="{StaticResource TextMutedBrush}"
           IsVisible="{Binding !Links.Count}" />

with the counterpart IsVisible="{Binding Links.Count}" on the list Border so
the two never show at once.

What to do

Apply the same pattern to src/LageBuch.App.Shared/Views/FilesView.axaml:

  • add an EmptyText block bound to the inverse of the file collection's count
  • bind the existing list Border visibility to the count so the empty frame
    does not sit behind the message
  • use TextMutedBrush, matching the Links tab

Keep the message German, calm and short. Something in the spirit of
Keine Dateien angehängt. fits the house style; the existing add button right
below already tells the user how to add one.

Scope this PR to FilesView only. Several other tabs have the same gap and will
get their own issues.

Verify

make test PROJECT=tests/LageBuch.Acceptance.Tests FILTER=Name~Files
make run

Difficulty: easy.


New here?

Comment to claim this issue and it is yours. If no pull request appears within
seven days it goes back in the pool, no hard feelings.

Before you open the PR, please skim CONTRIBUTING.md:
commits need DCO sign-off (git commit -s) and a Conventional Commit subject.
Changes under src/ additionally need an entry under ## [Unreleased] in
CHANGELOG.md — CI fails the PR otherwise.

Questions are welcome right here or in
Discussions.

Metadata

Metadata

Assignees

No one assigned

    Labels

    good first issueGood for newcomersuxUser interface and usability

    Type

    No type

    Projects

    No projects

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions