You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
security(android): apply the attachment open gate on Android and clean up the temp root #289
Follow-up to #285 (fix(files): sanitise attachment names and gate what the OS launcher may open) and the Android FileProvider PR from the same review.
#285 introduced AttachmentTempPaths.IsOpenableAttachment and made the desktop StorageProviderFileDialogService.OpenFileAsync refuse anything that is not an existing regular file with an allow-listed extension under the private temp root. The Android head does not apply that gate: AndroidFileDialogService.OpenFileAsync hands whatever path it receives to FileProvider.GetUriForFile with a MIME guessed from the extension and */* as fallback.
To do
Apply AttachmentTempPaths.IsOpenableAttachment(path) in AndroidFileDialogService.OpenFileAsync (and ShareFileAsync for attachment shares) and return without launching when it is false.
The temp root on Android is <cache>/lagebuch/, which the FileProvider exposes via the attachments cache-path entry; keep that in sync if the root moves.
Activity
fix(android): gate attachment open and share, sweep stale copies (#611)