Repository navigation
fix: give Freizeichen an icon on every platform - #17
Merged
Merged
Conversation
On GNOME the app showed a generic icon: there was no icon asset at all, so neither desktop entry named one and no window set one. Windows and macOS had none either. The master is src/Freizeichen.App/Assets/icon.svg, a handset sounding its dial tone on Lagebuch's tile in its signal-red/amber. `make icon` renders the committed icon-1024.png and icon.ico from it, as the macOS and Windows runners have no SVG renderer. - Linux: the .deb installs the icon into hicolor (every declared size plus scalable), its entry gains Icon= and StartupWMClass=, and it depends on hicolor-icon-theme. The entry "Als Standard festlegen" writes points at the freizeichen.svg published beside the executable. - Windows: the exe embeds icon.ico; the MSI uses it for the shortcut and the Installed apps entry. - macOS: the .dmg builds Freizeichen.icns and names it in Info.plist. - Both windows carry the icon. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Signed-off-by: Thomas Müller <1005065+DeepDiver1975@users.noreply.github.com>
DeepDiver1975
force-pushed
the
fix/app-icon
branch
from
October 27, 2026 22:11
c0a90d9 to
514efbc
Compare
The icon path tests failed on the Windows runner: Path.GetDirectoryName and Path.Join follow the host's rules, so /opt/freizeichen/Freizeichen became \opt\freizeichen\freizeichen.svg there, and a backslash in a Linux path was read as a separator. The entry always holds a Linux path, so split it on '/' instead. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Signed-off-by: Thomas Müller <1005065+DeepDiver1975@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On GNOME, Freizeichen showed a generic icon in the app grid, the dock and Alt-Tab. The cause wasn't the desktop entry alone: the app had no icon at all. There was no icon asset in the repo, so neither desktop entry could name one (
Icon=was missing) and no window set one (xpropshowed no_NET_WM_ICON). Windows and macOS had no icon either.The icon
src/Freizeichen.App/Assets/icon.svgis the master, styled after Lagebuch's icon: a handset sounding its dial tone, on Lagebuch's dark tile in its signal-red/amber, so the two read as one family.make icon(packaging/icon/build-icon-assets.sh, needsrsvg-convertand ImageMagick) renders the committedicon-1024.pngandicon.icofrom it. They're committed because the macOS and Windows runners have no SVG renderer.Where it goes
.deb: hicolor icons at every size the theme declares (16 to 512) plus the scalable SVG. The entry gainsIcon=freizeichenandStartupWMClass=Freizeichen(the window's WM_CLASS, checked withxprop). The package now depends onhicolor-icon-theme, which ownsindex.themeand refreshes the icon cache. A self-contained Avalonia app pulls in no GTK, so nothing else brings it in. CI installslibrsvg2-binto render the sizes and checks that the icons are installed.freizeichen.svg, which is now published beside the executable, and also getsStartupWMClass.icon.ico(ApplicationIcon). The MSI uses it for the Start menu shortcut and the Installed apps entry (ARPPRODUCTICON).build-dmg.shbuildsFreizeichen.icnsfrom the 1024 render withsips/iconutiland names it inInfo.plist.Icon. The window icon isn't part of the client area, so the headless Skia renders before and after are identical and not attached. The icon renders above stand in for them.Tests
LinuxTelHandlerRegistrationTests: three new tests, written first and failing before the fix: the entry names the icon beside the executable, escapes a backslash in that path, and carriesStartupWMClass.make clean ciis green, and zizmor reports nothing..debshows the icon in the app grid, dock and Alt-Tab, and the window now has a 128×128_NET_WM_ICON..dmgand the MSI. The.dmgleg doesn't run on pull requests, so a manual run of the release workflow on this branch would cover both.🤖 Generated with Claude Code