Skip to content

Limit drand relay calls in tests #7464

Closed

Description

@LesnyRumcajs

Summary

Unit tests should depend on external resources as little as possible (to reduce flakiness and be nice). Right now a single cargo nextest would make burst of ~23 calls to the drand HTTPS relay

      2 api2.drand.sh
      2 api3.drand.sh
     15 api.drand.sh
      4 drand.cloudflare.com

This doesn't count possible retries.

Completion Criteria

  • contrive a way to limit drand relay usage in tests. We already have some mocking mechanisms around there. Doing some memoization might also be fine, but ideally we'd go down to zero foreign calls.
  • check the calls done when running snapshot tests - the snapshot might need to get replaced if the node is able now to get data from block headers

Additional Links & Resources

Metadata

Metadata

Labels

Type: TaskDiscrete task to implement

Type

No type

Fields

Priority

None yet

Projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions